ci: fix node-manager upgrade image verification - #223
Merged
Conversation
Signed-off-by: Cooper Tseng <cooper.tseng@suse.com>
Member
Author
|
@mergify backport v1.9 v1.8 |
✅ Backports have been createdDetails
|
bk201
approved these changes
Aug 24, 2026
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI failed with error
see https://github.com/harvester/node-manager/actions/runs/32698393724/job/97344850263?pr=222
The original check selected the first running pod whose name started with harvester-node-manager. This also matched harvester-node-manager-webhook pods, so the script could read the webhook container image but compare it against the node-manager image override.
And the script also used
tr ":" \n, which replaced the colon with a literalnand made the logged image look likettl.sh/node-manager-webhook-ab456dfcn1h, but it should bettl.sh/node-manager-webhook-ab456dfc.Fix this by checking the exact workloads instead of selecting a pod by prefix. The script now reads the node-manager image from the DaemonSet and the webhook image from the webhook Deployment, then compares each one against its matching full
repository:tagvalue from the override file.