Skip to content

Add offline dual-provider adapters and immutable source reader - #180

Merged
HemSoft merged 3 commits into
mainfrom
feature/issue-174-dual-adapters
Oct 19, 2026
Merged

HemSoft merged 3 commits into
mainfrom
feature/issue-174-dual-adapters

Conversation

@HemSoft

@HemSoft HemSoft commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Add the separate offline reviewer module with both provider contracts, bounded immutable source access, and serialized fake-auth refresh storage. Record the owner-authorized offline exception while retaining the freeze for live operation and the retired modules.

Acceptance Criteria

  • Implement both pinned adapter contracts with pre/post auth identity checks, bounded strict output, no environment inheritance and no fallback.
  • Read captured Git objects without checkout; reject traversal, cross-job objects, links/submodules/binaries and exhausted limits while retaining coverage evidence.
  • Serialize trusted refresh transactions and persist current state atomically without interactive auth import or stale seed restoration.
  • Decode official-client JSONL/result envelopes, supply the same strict response schema, reject duplicate/null/missing fields and copy trusted immutable headers.
  • Supply a disabled live driver and document all unproven client/host controls.

Definition of Done

  • Add reviewer/go.mod, declared local gates, meaningful fake-provider/source/auth tests and the scoped AGENTS/README exception.
  • Full live portion of Build both subscription adapters and the isolated source reader #174: qualified live-client transport and separately enforced worker isolation and credential-bearing hostile probes need qualified infrastructure and activation authority. The issue stays open; fake contracts are not runtime proof.

Validation

  • go -C reviewer vet ./...: pass with Go 1.25.14.
  • go -C reviewer test -race -count=1 ./...: pass. Cases cover both providers, API-mode rejection before execution, quota/time/schema/provenance failures, source/canary boundaries, immutable reads and refresh concurrency/cancellation.
  • git diff --check: pass. Retired modules and workflows unchanged. Actions CI remains disabled.
  • Reviewers rerun these commands at this PR head; no live clients or GitHub writes run in tests.

Review provenance: Codex reviewed two heads, 535ee3d and 76ac889. The latest round reported three P2 findings and no P1. Both finding/fix rounds are complete at 520d7f2. The composing merge-mission bounded-review rule permits merge after local gates without another request. This corrected head is not described as clean-reviewed.

Risks and deferred work

No production launcher is shipped. Candidate CLI flags, turn/tool/resource enforcement and guest/network/OS identity boundaries need separate live qualification. #174 and the source tracker remain open for those gates.

Refs #174 and #172.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T05:14:50.812534Z 76ac889 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 535ee3d372

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread reviewer/contract.go Resolved
Comment thread reviewer/contract.go Resolved
Comment thread reviewer/contract.go Resolved
Comment thread reviewer/contract.go Resolved
@HemSoft

HemSoft commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 76ac889a84

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread reviewer/contract.go Resolved
Comment thread reviewer/adapter.go Resolved
Comment thread reviewer/contract.go Resolved
@HemSoft
HemSoft merged commit 372f563 into main Oct 19, 2026
@HemSoft
HemSoft deleted the feature/issue-174-dual-adapters branch October 19, 2026 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant