Repository navigation
Add offline dual-provider adapters and immutable source reader - #180
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 535ee3d372
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76ac889a84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Add the separate offline reviewer module with both provider contracts, bounded immutable source access, and serialized fake-auth refresh storage. Record the owner-authorized offline exception while retaining the freeze for live operation and the retired modules.
Acceptance Criteria
Definition of Done
Validation
go -C reviewer vet ./...: pass with Go 1.25.14.go -C reviewer test -race -count=1 ./...: pass. Cases cover both providers, API-mode rejection before execution, quota/time/schema/provenance failures, source/canary boundaries, immutable reads and refresh concurrency/cancellation.git diff --check: pass. Retired modules and workflows unchanged. Actions CI remains disabled.Review provenance: Codex reviewed two heads, 535ee3d and 76ac889. The latest round reported three P2 findings and no P1. Both finding/fix rounds are complete at 520d7f2. The composing merge-mission bounded-review rule permits merge after local gates without another request. This corrected head is not described as clean-reviewed.
Risks and deferred work
No production launcher is shipped. Candidate CLI flags, turn/tool/resource enforcement and guest/network/OS identity boundaries need separate live qualification. #174 and the source tracker remain open for those gates.
Refs #174 and #172.