Skip to content

chore: deploy Set it Free Loop (review tier, v2.0.0) - #1

Closed
HemSoft wants to merge 3 commits into
mainfrom
sfl/tier-review
Closed

HemSoft wants to merge 3 commits into
mainfrom
sfl/tier-review

Conversation

@HemSoft

@HemSoft HemSoft commented Aug 1, 2026 •

Copy link
Copy Markdown
Collaborator

Set it Free Loop — Deployment

Version: 2.0.0
Tier: review
Source SHA: 380fe0edc7a87cfc7b31233a955b37df0223a3a8
Engine policy: codex-gpt-55-high

Components deployed

  • labels
  • governance
  • sfl-pr-review

What is the Set it Free Loop?

The Set it Free Loop is a continuous
quality improvement operating model for software repositories. See the
CATALOG
for all available workflows.

Before merging

  • Run .\deployment\governance\setup-labels.ps1 -Owner <org> -Repo <repo> if labels are not yet configured
  • For each .md workflow: verify gh aw compile .github/workflows/<name>.md succeeds
  • Trigger a workflow manually to confirm output
  • Review sfl.json manifest in the repo root

Summary by cubic

Deploys the Set it Free Loop v2.0.0 (review tier) to run label-triggered full‑spectrum PR reviews via sfl-review. Uses OpenRouter moonshotai/kimi-k3 to post inline findings, a consolidated review, and the SFL Reviewer Approval check.

  • New Features

    • Added sfl-pr-review.md and its lock workflow; runs security, correctness, and maintainability passes on labeled PRs using OpenRouter moonshotai/kimi-k3.
    • Added sfl.json and an SFL badge in README.md for visibility and version tracking.
    • Governance updates: pinned github/gh-aw-actions/setup@v0.84.1, added .github/aw/actions-lock.json, and marked workflow lock files as generated in .gitattributes.
  • Migration

    • Set vars.SFL_APP_CLIENT_ID, secrets.SFL_APP_PRIVATE_KEY, and secrets.OPENROUTER_API_KEY.
    • Run .\deployment\governance\setup-labels.ps1 -Owner <org> -Repo <repo> if labels are not configured.
    • Compile the workflow (gh aw compile .github/workflows/sfl-pr-review.md) and test by applying sfl-review on a PR.

Written for commit 8a33f0b. Summary will update on new commits.

Review in cubic

Note

Deploy Set it Free Loop AI PR review workflow at v2.0.0 (review tier)

  • Adds sfl-pr-review.lock.yml, a compiled GitHub Actions workflow that triggers when the sfl-review label is applied to a PR, runs an AI-driven code review via the Kimi K3 model (OpenRouter), and posts inline comments, a consolidated APPROVE/REQUEST_CHANGES review, and a SFL Reviewer Approval check run.
  • Adds sfl-pr-review.md, the human-readable Agentic Workflows spec that defines the review policy, finding classification, inline comment format, and approval logic imported by the compiled workflow.
  • Adds sfl.json with SFL metadata (version 2.0.0, tier, component list, engine policy) and updates README.md with a dynamic version badge.
  • Pins workflow action SHAs via actions-lock.json and marks lock files as linguist-generated in .gitattributes.

Macroscope summarized 8a33f0b.

Source: hemsoft-dev/set-it-free-loop@380fe0e
Version: 2.0.0
Tier: review
Components: labels, governance, sfl-pr-review
Engine policy: codex-gpt-55-high

See https://github.com/HemSoft/set-it-free-loop for full documentation.
@cursor

cursor Bot commented Aug 1, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Added automated pull request reviews covering security, correctness, reliability, and maintainability.
    • Reviews provide severity-classified inline findings, consolidated results, approval checks, and status updates.
    • Added configurable review capabilities, including standard and high-effort review options.
    • Reviews can be initiated through a pull request label and process results with safety controls.
    • Added safeguards for authorization, output validation, usage limits, and failure reporting.
  • Documentation

    • Added an automatically updated version badge and deployment status marker to the README.

Walkthrough

Adds Set it Free Loop configuration and a generated GitHub Actions workflow for sfl-review-labeled pull requests. The workflow runs review passes, validates outputs, enforces usage controls, and publishes review results.

Changes

Set it Free Loop review

Layer / File(s) Summary
Review workflow definition and configuration
.github/workflows/sfl-pr-review.md, sfl.json, .github/aw/actions-lock.json, .gitattributes, README.md
Defines the review policy, enabled components, model settings, pinned setup action, generated workflow handling, and repository metadata.
Review workflow activation
.github/workflows/sfl-pr-review.lock.yml
Implements label-based activation, authorization checks, usage guardrails, secret validation, prompt rendering, repository preparation, and activation artifact handling.
Generated review workflow execution
.github/workflows/sfl-pr-review.lock.yml
Runs the isolated review agent, validates safe outputs, records usage, publishes results, and reports failures.

Estimated code review effort: 4 (Complex) | ~45 minutes

Suggested labels: feature

Poem

I’m a rabbit reviewing the flow,
With pinned little actions in tow.
Copilot checks each change,
Safe outputs keep order in range.
The sfl-review label starts the show.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the deployment of Set it Free Loop version 2.0.0 at the review tier.
Description check ✅ Passed The description directly explains the Set it Free Loop deployment, workflow changes, configuration, and pre-merge checks.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sfl/tier-review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@macroscopeapp

macroscopeapp Bot commented Aug 1, 2026 •

Copy link
Copy Markdown

Approvability

Verdict: Needs human review

Unable to check for correctness in 8a33f0b. This PR deploys a new automated PR review system with approval capabilities, representing significant new functionality rather than a minor change. An unresolved review comment also identifies a potential false approval risk from hardcoded template defaults.

You can customize Macroscope's approvability policy. Learn more.

@coderabbitai coderabbitai Bot added the feature label Aug 1, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ae4e8014ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/sfl-pr-review.md Outdated
Comment on lines +9 to +11
pull_request:
types: [labeled]
names: [sfl-review]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Skip draft pull requests until they are reviewable

When sfl-review is applied to a draft pull request, this trigger starts the workflow even though the required consolidated result is always APPROVE or REQUEST_CHANGES; GitHub does not allow approval of a draft PR, so at least the zero/Medium/Low paths fail to publish the promised review. Add a draft guard to this workflow or trigger a new run when the PR becomes ready for review.

Useful? React with 👍 / 👎.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.gitattributes:
- Line 1: Update the .gitattributes entry for .github/workflows/*.lock.yml by
either documenting and configuring the required merge.ours driver with "true"
for contributors, or removing merge=ours and relying on lock-file regeneration
after merges; preserve linguist-generated=true.

In @.github/workflows/sfl-pr-review.md:
- Around line 51-52: The deployment marker is being parsed as the workflow
heading, causing SHA-bearing workflow names. In
.github/workflows/sfl-pr-review.md lines 51-52, wrap both marker lines in an
HTML comment and recompile, keeping “SFL Review - Full-Spectrum Pull Request
Review” as the first heading at line 75. In
.github/workflows/sfl-pr-review.lock.yml lines 58-72, make no manual change;
verify recompilation produces the expected name and run-name.
- Around line 141-167: Replace the hardcoded APPROVE verdict and zero severity
counts in the SFL review body template with unmistakable unresolved placeholders
that cannot be interpreted as a valid review result. Update the template block
under “SFL Full-Spectrum Review” while preserving the existing substitution
instruction and review structure.

In `@README.md`:
- Around line 3-6: Remove the repeated “# Subtitle Translator” heading from
README.md while preserving the original title and badge order. Update the badge
insertion logic in deploy-workflow.ps1 so future deployments insert or replace
the badge without adding another H1 heading.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ce758129-0eb6-4788-9052-d7e5ffa5d7fc

📥 Commits

Reviewing files that changed from the base of the PR and between 8063488 and ae4e801.

📒 Files selected for processing (6)
  • .gitattributes
  • .github/aw/actions-lock.json
  • .github/workflows/sfl-pr-review.lock.yml
  • .github/workflows/sfl-pr-review.md
  • README.md
  • sfl.json

Comment thread .gitattributes
@@ -0,0 +1 @@
.github/workflows/*.lock.yml linguist-generated=true merge=ours No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

git attributes merge=ours custom merge driver config required

💡 Result:

To configure a custom merge driver that ignores incoming changes and preserves your local version of a file (often referred to as an "ours" merge strategy), you must define the driver in your Git configuration and assign it via.gitattributes [1][2]. 1. Define the Merge Driver Git does not have a built-in "ours" merge driver by default [3]. You must define one that essentially does nothing—because the file is already in your working directory ("ours"), a driver that exits successfully without changing the file will achieve the desired effect [4][2]. Run the following command in your repository (or use --global for a user-wide setting): git config merge.ours.driver true This command sets the driver to the shell command true, which always exits with a zero (success) status without modifying the file, effectively preserving your local version [1][2]. 2. Assign the Attribute Once defined, you must tell Git which files should use this driver by creating or updating a.gitattributes file in your repository [1][2]: echo "path/to/file.ext merge=ours" >>.gitattributes Replace path/to/file.ext with the path to the specific file or files you want to protect [1][2]. Important Limitations and Considerations - Execution Condition: The merge driver is only invoked when Git attempts a three-way merge, typically when both the local branch and the incoming branch have modified the same file [4][5][3]. If only the incoming branch has modified the file, Git will simply accept those changes; the driver will not be triggered [4][3]. - Configuration Persistence: The merge driver configuration (stored in.git/config) is local to your machine [6]. It is not version-controlled and cannot be committed to the repository [6]. This means that every team member who needs this merge behavior must manually run the git config command on their own machine [2]. - Not a Global Strategy: This approach is a low-level merge driver for specific files [1][7]. It is distinct from the recursive merge strategy option -Xours, which is applied at the command level during a merge operation [8]. For many workflows, if you need to maintain branch-specific configurations (like database settings), using a template file with a content filter driver or a post-checkout hook is often more reliable than relying on the merge=ours driver [5][3].

Citations:


🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '--- .gitattributes ---\n'
cat -n .gitattributes

printf '\n--- workflow files of interest ---\n'
git ls-files '.github/workflows/*' | sed -n '1,160p'

printf '\n--- referenced stale-lock check/snippet locations ---\n'
if [ -f .github/workflows/sfl-pr-review.lock.yml ]; then
  nl -ba .github/workflows/sfl-pr-review.lock.yml | sed -n '190,230p'
fi

printf '\n--- occurrences of merge driver or stale lock references ---\n'
rg -n "merge\.ours|merge=ours|stale|lock.*source|\.lock\.yml" .github README.md CONTRIBUTING.md 2>/dev/null || true

Repository: HemSoft/subtitle-translator

Length of output: 256


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "--- .gitattributes ---"
cat -n .gitattributes

echo
echo "--- workflow files of interest ---"
git ls-files '.github/workflows/*' | sed -n '1,160p'

echo
echo "--- referenced stale-lock check/snippet locations ---"
if [ -f .github/workflows/sfl-pr-review.lock.yml ]; then
  nl -ba .github/workflows/sfl-pr-review.lock.yml | sed -n '190,230p'
fi

echo
echo "--- occurrences of merge driver or stale lock references ---"
rg -n "merge\.ours|merge=ours|stale|lock.*source|\.lock\.yml" .github README.md CONTRIBUTING.md 2>/dev/null || true

Repository: HemSoft/subtitle-translator

Length of output: 466


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "--- .github/workflows/sfl-pr-review.lock.yml lines 190-230 ---"
awk 'NR>=190 && NR<=230 { printf "%6d\t%s\n", NR, $0 }' .github/workflows/sfl-pr-review.lock.yml

echo
echo "--- docs/config for merge.ours or generated lock files ---"
python3 - <<'PY'
from pathlib import Path
patterns=[
    "merge.ours", "merge=ours", "stale", "lock file", ".lock.yml", "lock.yml",
    "git config"
]
for p in ["README.md", "CONTRIBUTING.md", "docs", ".github"]:
    path = Path(p)
    if path.is_file():
        if any(pat in path.read_text(errors="ignore").lower() for pat in [x.lower() for x in patterns]):
            print(f"FILE {path}")
            text=path.read_text(errors="ignore").lower()
            for line_no,line in enumerate(text.splitlines(),1):
                if any(pat in line for pat in [x.lower() for x in patterns]):
                    print(f"{line_no}: {line[:240]}")
    elif path.is_dir():
        for f in path.rglob("*"):
            if f.is_file() and f.suffix.lower() in {".md",".txt",".yml",".yaml"}:
                try:
                    text=f.read_text(errors="ignore").lower()
                except Exception:
                    continue
                if any(x.lower() in text for x in patterns):
                    print(f"FILE {f}")
                    for line_no,line in enumerate(text.splitlines(),1):
                        if any(pat in line for pat in [x.lower() for x in patterns]):
                            print(f"{line_no}: {line[:240]}")
PY

Repository: HemSoft/subtitle-translator

Length of output: 3786


🌐 Web query:

Git merge attribute named conflict fallback driver output

💡 Result:

In Git, a custom merge driver is a user-defined command invoked during a merge to handle content-level conflicts for specific files [1][2]. These drivers are defined in your Git configuration and associated with files via the.gitattributes file [2][3]. Configuration and Operation To define a custom merge driver, you add a section to your Git configuration file (e.g.,.gitconfig) and set the driver command [2][3]: [merge "driver-name"] name = Human-readable description driver = /path/to/command %O %A %B %L %P The driver command receives several parameters [2][3]: %O: The temporary file containing the common ancestor version. %A: The temporary file containing the current version (the branch being merged into). This file must be overwritten by the driver with the merge result [2][4]. %B: The temporary file containing the other branch's version. %L: The conflict marker size. %P: The path of the file being merged. Expectations The merge driver is expected to [2][3]: 1. Perform the merge and overwrite the file specified by %A with the result. 2. Exit with status 0 if the merge was successful (clean). 3. Exit with a non-zero status if there were conflicts. Important Nuance: Drivers run even if no conflict exists, provided the file has changed in both branches compared to the base [5][6]. If your driver is intended only for conflicts, it must detect whether a clean merge is possible (often by attempting a standard merge first) before applying custom logic [6]. If a driver crashes or exits with a status higher than 128, Git treats it as an error [2][3]. Linking to Paths Once defined, you associate the driver with specific files using.gitattributes [7][2]: *.ext merge=driver-name This tells Git to use the "driver-name" configuration for any file matching the pattern [1][7]. The built-in drivers (like "text", "binary", and "union") can also be specified this way [8].

Citations:


🌐 Web query:

gitattributes merge attribute undefined merge driver output documentation

💡 Result:

In Git, the merge attribute in.gitattributes defines which merge driver to use for specific files during a merge operation [1][2][3]. If you assign a merge driver name (e.g., merge=my-driver) but fail to define that driver in your Git configuration, Git will default to its built-in merge driver [3][4]. Key points regarding undefined or missing merge drivers: 1. Fallback Behavior: If a merge driver name is specified in.gitattributes (e.g., path/to/file merge=undefined-driver) but no corresponding [merge "undefined-driver"] section exists in your.git/config or.gitconfig, Git treats this as an error or ignores the directive, typically falling back to the default internal 3-way merge driver [3][4]. It does not prevent the merge from occurring; it simply performs the merge using the standard built-in logic [3]. 2. When Drivers Are Invoked: A custom merge driver is only invoked when Git determines that a low-level, file-content merge is required [5][6]. If Git performs a tree-level merge (e.g., one side modified the file and the other did not, or if there is no conflict), it will not trigger the merge driver at all, regardless of the.gitattributes setting [5][4]. 3. Configuration Requirement: To make a custom merge driver effective, you must explicitly define it in your Git configuration [1][7]. For example: git config merge.my-driver.driver "path/to/script %O %A %B" git config merge.my-driver.name "My custom merge driver" If you intend to use a specific behavior like "ours" or "theirs" for a file, you must define those drivers in your configuration as well; simply adding the attribute to.gitattributes is insufficient on its own [4][8][7].

Citations:


Define the ours merge driver or remove the attribute.

merge=ours requires git config merge.ours.driver "true". Contributors without this local config will get the default merge driver behavior for .github/workflows/<name>.lock.yml instead of the intended ignore-incoming-changes behavior. Add this config requirement to contribution docs if this behavior is required, or remove merge=ours and rely on regenerating the lock file after merges.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.gitattributes at line 1, Update the .gitattributes entry for
.github/workflows/*.lock.yml by either documenting and configuring the required
merge.ours driver with "true" for contributors, or removing merge=ours and
relying on lock-file regeneration after merges; preserve
linguist-generated=true.

Comment thread .github/workflows/sfl-pr-review.md Outdated
Comment on lines +51 to +52
# Deployed from: HemSoft/set-it-free-loop/deployment/workflows/sfl-pr-review.md@380fe0edc7a87cfc7b31233a955b37df0223a3a8
# To upgrade: re-run deploy-workflow.ps1 at the desired SHA

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

The deployment marker became the workflow name. Lines 51 and 52 of the markdown body start with #, so markdown treats Line 51 as the first heading. The compiler used that heading as the workflow name and run-name. The result is a SHA-bearing provenance string in the Actions UI, in GH_AW_WORKFLOW_NAME, and in the titles of generated failure issues.

  • .github/workflows/sfl-pr-review.md#L51-L52: change the two marker lines to an HTML comment so markdown does not treat them as a heading, then recompile. For example, wrap both lines in <!-- ... -->. Keep # SFL Review - Full-Spectrum Pull Request Review at Line 75 as the first heading.
  • .github/workflows/sfl-pr-review.lock.yml#L58-L72: no manual change. Recompile after the markdown fix and confirm that name and run-name read SFL Review - Full-Spectrum Pull Request Review.
🧰 Tools
🪛 markdownlint-cli2 (0.23.1)

[warning] 51-51: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


[warning] 52-52: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Above

(MD022, blanks-around-headings)

📍 Affects 2 files
  • .github/workflows/sfl-pr-review.md#L51-L52 (this comment)
  • .github/workflows/sfl-pr-review.lock.yml#L58-L72
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/sfl-pr-review.md around lines 51 - 52, The deployment
marker is being parsed as the workflow heading, causing SHA-bearing workflow
names. In .github/workflows/sfl-pr-review.md lines 51-52, wrap both marker lines
in an HTML comment and recompile, keeping “SFL Review - Full-Spectrum Pull
Request Review” as the first heading at line 75. In
.github/workflows/sfl-pr-review.lock.yml lines 58-72, make no manual change;
verify recompilation produces the expected name and run-name.

Comment on lines +141 to +167
```markdown
## SFL Full-Spectrum Review

SFL run ID: ${{ github.run_id }}
Head SHA: ${{ github.event.pull_request.head.sha }}
Verdict: APPROVE

| Severity | Count |
| --- | ---: |
| Critical | 0 |
| High | 0 |
| Medium | 0 |
| Low | 0 |

### Review passes

- Security: complete
- Correctness and Reliability: complete
- Quality and Maintainability: complete

### Summary

Concise evidence-based summary of the review result.
```

Replace the verdict and counts with the actual result. Use
`Verdict: CHANGES_REQUESTED` when Critical or High findings exist.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Replace the permissive default values in the review body template.

The template hardcodes Verdict: APPROVE and zero counts for every severity. The instruction to replace the values follows the template at Line 166. If the agent copies the template without substitution, the review body reports an approving verdict and zero findings even when inline Critical findings exist. That produces a false approval on the review gate.

Use placeholders that cannot pass as a valid result. A placeholder value forces substitution and makes an unsubstituted body visible.

🛡️ Proposed fix for the template defaults
 SFL run ID: ${{ github.run_id }}
 Head SHA: ${{ github.event.pull_request.head.sha }}
-Verdict: APPROVE
+Verdict: <APPROVE or CHANGES_REQUESTED>
 
 | Severity | Count |
 | --- | ---: |
-| Critical | 0 |
-| High | 0 |
-| Medium | 0 |
-| Low | 0 |
+| Critical | <count> |
+| High | <count> |
+| Medium | <count> |
+| Low | <count> |
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
```markdown
## SFL Full-Spectrum Review
SFL run ID: ${{ github.run_id }}
Head SHA: ${{ github.event.pull_request.head.sha }}
Verdict: APPROVE
| Severity | Count |
| --- | ---: |
| Critical | 0 |
| High | 0 |
| Medium | 0 |
| Low | 0 |
### Review passes
- Security: complete
- Correctness and Reliability: complete
- Quality and Maintainability: complete
### Summary
Concise evidence-based summary of the review result.
```
Replace the verdict and counts with the actual result. Use
`Verdict: CHANGES_REQUESTED` when Critical or High findings exist.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/sfl-pr-review.md around lines 141 - 167, Replace the
hardcoded APPROVE verdict and zero severity counts in the SFL review body
template with unmistakable unresolved placeholders that cannot be interpreted as
a valid review result. Update the template block under “SFL Full-Spectrum
Review” while preserving the existing substitution instruction and review
structure.

Comment thread README.md
Comment on lines +3 to +6
[![Set it Free Loop](https://img.shields.io/badge/dynamic/json?url=https%3A%2F%2Fraw.githubusercontent.com%2FHemSoft%2Fsubtitle-translator%2Fmain%2Fsfl.json&query=%24.version&prefix=v&label=Set%20it%20Free%20Loop&color=FFD700&style=flat&logo=githubactions&logoColor=white)](https://github.com/HemSoft/set-it-free-loop)
<!-- SFL_BADGE: auto-updated by deploy-workflow.ps1 -->
# Subtitle Translator

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Remove the duplicated H1 heading.

Line 1 already contains # Subtitle Translator. Line 5 repeats it. The rendered README shows the title, then the badge, then the title again. markdownlint reports MD024 for Line 5.

Keep the badge below the original title and delete the repeated heading. The duplication comes from the badge insertion in deploy-workflow.ps1, so fix the generator as well to prevent the duplication on the next deployment.

📝 Proposed fix for the duplicated title
 # Subtitle Translator
 
 [![Set it Free Loop](https://img.shields.io/badge/dynamic/json?url=https%3A%2F%2Fraw.githubusercontent.com%2FHemSoft%2Fsubtitle-translator%2Fmain%2Fsfl.json&query=%24.version&prefix=v&label=Set%20it%20Free%20Loop&color=FFD700&style=flat&logo=githubactions&logoColor=white)](https://github.com/HemSoft/set-it-free-loop)
 <!-- SFL_BADGE: auto-updated by deploy-workflow.ps1 -->
-# Subtitle Translator
 
🧰 Tools
🪛 markdownlint-cli2 (0.23.1)

[warning] 5-5: Multiple headings with the same content

(MD024, no-duplicate-heading)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` around lines 3 - 6, Remove the repeated “# Subtitle Translator”
heading from README.md while preserving the original title and badge order.
Update the badge insertion logic in deploy-workflow.ps1 so future deployments
insert or replace the badge without adding another H1 heading.

Source: Linters/SAST tools

HemSoft added 2 commits August 1, 2026 21:18
Source: hemsoft-dev/set-it-free-loop@235a0df
Version: 2.0.0
Tier: review
Components: labels, governance, sfl-pr-review
Engine policy: codex-gpt-55-high

See https://github.com/HemSoft/set-it-free-loop for full documentation.
Source: hemsoft-dev/set-it-free-loop@78483bb
Version: 2.0.0
Tier: review
Components: labels, governance, sfl-pr-review
Engine policy: codex-gpt-55-high

See https://github.com/HemSoft/set-it-free-loop for full documentation.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/aw/actions-lock.json:
- Around line 3-6: Update the PR description to reference
github/gh-aw-actions/setup version v0.84.1, matching the pinned version and SHA
in the actions-lock.json entry and corresponding generated workflow references.

In `@sfl.json`:
- Around line 3-6: Align the deployment provenance across sfl.json and
.github/workflows/sfl-pr-review.md: choose the SHA that was actually deployed,
set sfl.json’s sourceSha accordingly, update the workflow’s “Deployed from”
marker and sfl: version to match, then recompile the workflow.
- Around line 17-21: Update the openrouter-kimi-k3-high profile in sfl.json to
set effort to high, then recompile the generated configuration so renderedModel
and the corresponding COPILOT_MODEL values include the high-effort suffix. If
the provider rejects that suffix for moonshotai/kimi-k3, instead rename the
profile to remove the high-effort claim.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fdb020cd-fb1a-4df5-a889-35be3fdc2393

📥 Commits

Reviewing files that changed from the base of the PR and between 860957c and 8a33f0b.

📒 Files selected for processing (4)
  • .github/aw/actions-lock.json
  • .github/workflows/sfl-pr-review.lock.yml
  • .github/workflows/sfl-pr-review.md
  • sfl.json

Comment on lines +3 to +6
"github/gh-aw-actions/setup@v0.84.1": {
"repo": "github/gh-aw-actions/setup",
"version": "v0.84.1",
"sha": "029204130cb73f6ba684e56428c7f3e9319b708c"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify the tag-to-SHA mapping for the pinned setup action.
set -euo pipefail
gh api repos/github/gh-aw-actions/git/ref/tags/v0.84.1 --jq '{ref: .ref, type: .object.type, sha: .object.sha}' || true
# If the tag is annotated, resolve it to the commit.
gh api repos/github/gh-aw-actions/commits/v0.84.1 --jq '.sha' || true

Repository: HemSoft/subtitle-translator

Length of output: 296


Update the PR description to match the pinned action version.

.github/aw/actions-lock.json pins github/gh-aw-actions/setup@v0.84.1 to 029204130cb73f6ba684e56428c7f3e9319b708c, while the PR description says v0.83.4. The lockfile includes the same SHA at .github/workflows/sfl-pr-review.lock.yml lines 116, 476, 1089, 1351, and 1409, so the generated workflow is internally consistent.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/aw/actions-lock.json around lines 3 - 6, Update the PR description
to reference github/gh-aw-actions/setup version v0.84.1, matching the pinned
version and SHA in the actions-lock.json entry and corresponding generated
workflow references.

Comment thread sfl.json
Comment on lines +3 to +6
"deployedAt": "2026-08-02T04:33:47Z",
"tier": "review",
"source": "HemSoft/set-it-free-loop",
"sourceSha": "78483bbf7edf0a4f8d3bf2f68e58678da36044ae",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

The recorded deployment provenance does not match the PR description. The PR description states version 2.0.0 from source SHA 380fe0edc7a87cfc7b31233a955b37df0223a3a8. Both files record SHA 78483bbf7edf0a4f8d3bf2f68e58678da36044ae, and the markdown records version: "1.0.0". One of the two is stale. A wrong provenance record makes the deployed workflow untraceable to its source revision.

  • sfl.json#L3-L6: set sourceSha to the SHA that was actually deployed, or correct the PR description.
  • .github/workflows/sfl-pr-review.md#L61-L62: update the Deployed from: ...@<sha> marker and the version field in the sfl: block so both match sfl.json, then recompile.
📍 Affects 2 files
  • sfl.json#L3-L6 (this comment)
  • .github/workflows/sfl-pr-review.md#L61-L62
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@sfl.json` around lines 3 - 6, Align the deployment provenance across sfl.json
and .github/workflows/sfl-pr-review.md: choose the SHA that was actually
deployed, set sfl.json’s sourceSha accordingly, update the workflow’s “Deployed
from” marker and sfl: version to match, then recompile the workflow.

Comment thread sfl.json
Comment on lines +17 to +21
"profile": "openrouter-kimi-k3-high",
"provider": "copilot",
"model": "moonshotai/kimi-k3",
"effort": null,
"renderedModel": "moonshotai/kimi-k3",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

The -high profile does not render a high reasoning effort.

Line 17 selects the profile openrouter-kimi-k3-high, but Line 20 sets effort to null and Line 21 renders the model as moonshotai/kimi-k3. The PR description states the engine is moonshotai/kimi-k3?effort=high. .github/workflows/sfl-pr-review.lock.yml also sets COPILOT_MODEL: moonshotai/kimi-k3 (Line 889) and .github/workflows/sfl-pr-review.md sets the same value (Line 30). The review agent will therefore run at the provider default effort, not high.

Set effort to high and recompile, so the rendered model and COPILOT_MODEL carry the effort suffix. If OpenRouter does not accept the ?effort= suffix for this model, rename the profile so it does not claim high effort.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@sfl.json` around lines 17 - 21, Update the openrouter-kimi-k3-high profile in
sfl.json to set effort to high, then recompile the generated configuration so
renderedModel and the corresponding COPILOT_MODEL values include the high-effort
suffix. If the provider rejects that suffix for moonshotai/kimi-k3, instead
rename the profile to remove the high-effort claim.

@HemSoft

HemSoft commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator Author

Closing this v2.0.0 SFL rollout as superseded. HemSoft now uses v2.1.0-rc.9, and hs-buddy is the only approved HemSoft SFL validation repository. This old deployment should not be merged or refreshed.

@HemSoft HemSoft closed this Aug 16, 2026
@HemSoft
HemSoft deleted the sfl/tier-review branch August 16, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant