Repository navigation
docs: prepare iOS release records privacy audit and store metadata - #104
Conversation
|
@sfl review |
There was a problem hiding this comment.
🟡 Changes recommended
The release-notes source removes the draft marker while the tracker and checker still depend on it as a fail-closed guard, creating a risk that unapproved metadata could be treated as upload-ready.
1 open issue
What changed in this PR
This PR updates iOS 1.0.0 release tracking by adding version-specific release notes, binding the draft candidate to the native bundle identity, version, and build, and recording current website and unsigned qualification evidence without claiming store readiness.
Changes:
- Added checked version-to-note mapping and tracked-source validation.
- Added proposed 1.0.0 release notes and first-release metadata copy.
- Updated candidate metadata, changelog, and App Store tracking with current evidence and remaining release blockers.
| File | Description |
|---|---|
scripts/ios-release/tracker.test.mjs |
Verifies candidate identity, marketing version, and build against native configuration. |
scripts/ios-release/check.test.mjs |
Tests versioned release-note path validation. |
scripts/ios-release/check.mjs |
Validates version-note mappings and includes notes in tracked source checks. |
History/2026-11-02.md |
Records the release-tracking update. |
apps/mobile/release/notes/1.0.0.md |
Adds proposed first-release iOS notes and future release guidance. |
apps/mobile/release/metadata/en-US/release_notes.txt |
Adds proposed first-release metadata copy. |
apps/mobile/release/candidate.json |
Binds the draft candidate to the native bundle identifier and versioned notes. |
apps/mobile/CHANGELOG.md |
Updates unreleased iOS entries and website references. |
apps/mobile/APP-STORE.md |
Records public-site and unsigned qualification evidence and documents release-check requirements. |
Review effort: Lite
There was a problem hiding this comment.
✅ Verdict: PASS • Round 1
Review done by gpt-6.1-sol
Adds versioned iOS release notes, validates their version and committed content, and updates release records while preserving draft acceptance gates. Security, accuracy and quality passes found no evidenced defects within the static coverage, supporting a clean verdict without proving correctness.
🔨 Full-Spectrum Review Summary
Effort: high
Review time: 3m 0s
Token count: Unavailable
| Pass | 🔴 Critical | 🟠 High | 🟡 Medium | ⚪ Low |
|---|---|---|---|---|
| 🔒 Security | 0 | 0 | 0 | 0 |
| ✅ Accuracy | 0 | 0 | 0 | 0 |
| 🧰 Quality & Maintainability | 0 | 0 | 0 | 0 |
| Total | 0 | 0 | 0 | 0 |
Key Findings
No material defects found.
Coverage
- Files reviewed:
History/2026-11-02.mdapps/mobile/APP-STORE.mdapps/mobile/CHANGELOG.mdapps/mobile/release/candidate.jsonapps/mobile/release/metadata/en-US/release_notes.txtapps/mobile/release/notes/1.0.0.mdscripts/ios-release/check.mjsscripts/ios-release/check.test.mjsscripts/ios-release/tracker.test.mjs
- Context read:
AGENTS.mdCLAUDE.mdpackage.json.github/workflows/quality.yml.github/workflows/site-pages.ymlscripts/ios-release/evidence.mjsscripts/ios-release/evidence.test.mjsscripts/ios-release/support.test.mjsapps/mobile/app.jsonapps/mobile/app/_layout.tsxapps/mobile/release/metadata/en-US/listing.jsonapps/mobile/src/local/LocalProvider.tsxapps/mobile/src/local/store.tsapps/mobile/src/local/save.tsapps/mobile/src/local/sqliteStorage.tsapps/mobile/src/local/platformStorage.native.tsapps/mobile/src/local/diagnostics.tsapps/mobile/src/screens/NativeGameScreen.tsxapps/mobile/src/screens/Setup.tsxapps/mobile/src/screens/Play.tsxapps/mobile/src/screens/Dice.tsxapps/mobile/src/screens/Help.tsxapps/mobile/src/screens/History.tsxapps/mobile/src/screens/Results.tsxpackages/game-engine/src/session.tspackages/game-engine/src/storage.tsdocs/mobile-release-brief.mdsite/pages.mjssite/assets/provenance.json
- Verified:
- Compare
base_commit.shamatches754d0f9806cf04d6c45b96ebee957cef444c0a17; its sole head commit matchesf0fd0a9345a38363fde6b7e36fdf63d34e09ffb4. - Inspected the complete nine-file diff and relevant source at the reserved head.
draftErrorsrequires the version-specific notes path;sourceFilespasses notes throughreadSource, including committed-text comparison in release mode.- The new notes path retains
relativeSourcevalidation and uses argument-based Git invocation. - Candidate identity, version and build match
app.json; store, archive and approval evidence remain unset. copyBlockersstill requires approved listing status and matching review hashes despite removal of the release-copy draft banner.- Native setup, session, persistence, history and Help implementations support the new gameplay, recovery, appearance and diagnostics descriptions.
- Inspected negative version-note tests, native configuration assertions and existing source-integrity tests.
- GitHub records confirm the documented merge SHA, successful Pages deployment and successful qualification attempt at source
dee3455. - The Pages API reports HTTPS enforcement; website source advertises development status without a store download.
- Compare
- Not verified:
- Runtime behavior and signed-device acceptance are outside this static review.
- Historical browser checks, HTTP responses, navigation and screenshot fidelity cannot be independently established through the permitted GitHub APIs.
- Original qualification failure details, retained diagnostic artifacts and rerun authorization were not independently verified.
- Session-authority assertions, App Store access history and legal or store acceptance require separate owner or external evidence.
- Existing historical packaging, privacy and asset-license claims were not independently requalified.
- Tests run: None. Reviewer execution is disabled.
HemSoft full-spectrum review • 3 evidence-based passes • Reviewed head f0fd0a9345a38363fde6b7e36fdf63d34e09ffb4 • SFL v0
|
@sfl review |
|
SFL review skipped: PR closed or head/base moved; post a fresh request. |
|
@sfl review |
|
@sfl review |
|
SFL review stopped: head moved; post a fresh request. |
There was a problem hiding this comment.
✅ Verdict: PASS • Round 2
Since round 1
New: 1; still open (repeated): 0; resolved: 0.
Resolved means no matching finding in this review, not independent proof of a fix.
New (1)
- LOW Correct the repository-root evidence links at
apps/mobile/release/product-page.md:53
Still open (repeated) (0)
- None.
Resolved (0)
- None.
Review done by gpt-6.1-sol
Adds version-bound iOS release notes, draft store metadata and a retained native privacy inventory. Security, accuracy and quality review found one low documentation defect and no evidenced blocking defects, supporting PASS within the stated static coverage.
🔨 Full-Spectrum Review Summary
Effort: high
Review time: 2m 24s
Token count: Unavailable
| Pass | 🔴 Critical | 🟠 High | 🟡 Medium | ⚪ Low |
|---|---|---|---|---|
| 🔒 Security | 0 | 0 | 0 | 0 |
| ✅ Accuracy | 0 | 0 | 0 | 0 |
| 🧰 Quality & Maintainability | 0 | 0 | 0 | 1 |
| Total | 0 | 0 | 0 | 1 |
Key Findings
- ⚪ LOW — Quality & Maintainability: Correct the repository-root evidence links.
apps/mobile/release/product-page.md:53: Following the session, scoring, release-brief or storage-contract links resolves their../../../targets underapps/, where the referenced files do not exist. This breaks four links in the claim-to-evidence table and prevents readers from reaching its supporting implementation and contracts. These root-level targets require../../../../from this document. (non-blocking)
Coverage
- Files reviewed:
History/2026-11-02.mdapps/mobile/APP-STORE.mdapps/mobile/CHANGELOG.mdapps/mobile/release/candidate.jsonapps/mobile/release/metadata/en-US/description.txtapps/mobile/release/metadata/en-US/listing.jsonapps/mobile/release/metadata/en-US/release_notes.txtapps/mobile/release/metadata/en-US/review_notes.txtapps/mobile/release/notes/1.0.0.mdapps/mobile/release/product-page.mddocs/mobile-privacy-audit.mddocs/privacy/2026-11-02-native.jsonscripts/ios-release/check.mjsscripts/ios-release/check.test.mjsscripts/ios-release/tracker.test.mjs
- Context read:
AGENTS.mdCLAUDE.mdpackage.json.github/workflows/quality.ymlapps/mobile/app.jsonapps/mobile/package.jsonapps/mobile/PRIVACY.mdapps/mobile/native/Podfile.lockapps/mobile/app/_layout.tsxapps/mobile/release/screenshots.jsonapps/mobile/src/local/LocalProvider.tsxapps/mobile/src/local/diagnostics.tsapps/mobile/src/local/platformStorage.native.tsapps/mobile/src/local/save.tsapps/mobile/src/local/sqliteStorage.tsapps/mobile/src/local/store.tsapps/mobile/src/screens/Setup.tsxapps/mobile/src/screens/Help.tsxapps/mobile/src/screens/NativeGameScreen.tsxapps/mobile/src/screens/Play.tsxapps/mobile/src/screens/History.tsxapps/mobile/src/screens/Results.tsxpackages/game-engine/src/session.tspackages/game-engine/src/scoring.tspackages/game-engine/src/storage.tsscripts/ios-release/evidence.mjsscripts/ios-release/evidence.test.mjsscripts/ios-native/privacy.mjsdocs/mobile-offline.mddocs/mobile-release-brief.mdsite/pages.mjs
- Verified:
- Compare
base_commit.shamatches754d0f9806cf04d6c45b96ebee957cef444c0a17; final compare commit matchesdf191b15aa7279401ae2a4b7939c7dd2ccdf6649. - Inspected the complete 15-file diff and relevant exact-head source.
draftErrorsenforces the version-specific notes path;sourceFilesincludes its contents in committed-text validation.readSourceretains path validation, nonempty-content checks and normalized committed-text comparison.- Candidate identity, version and build match
app.json; acceptance references remain unset. - Store-copy banners, draft review statuses and approval-hash requirements retain release blockers.
- Setup and session source support the documented modes, opponents, automatic first roll and two rerolls.
- Scoring source supports Full Straight 50, distinct-triple Castle and whole-hand All of a Kind.
- Storage source supports acknowledged saves, identical-state retries, explicit recovery/reset and bounded local history/rankings.
- Help and diagnostics source support appearance choices and optional allowlist sharing through the OS sheet.
- Privacy inventory dependency versions agree with inspected package declarations and resolved Pod entries.
privacy.mjscompares the FileSystem resource with SDK declarations and checks aggregate required reasons.- GitHub records confirm successful historical Pages deployment and qualification attempt 2 at their documented source SHAs.
- Pages API reports the documented site URL with HTTPS enforcement.
- Compare
- Not verified:
- Retained archive bytes, manifest hashes, compiled plist observations and independent inspection receipts were not reconstructed from the original artifact.
- Historical browser responses, navigation and screenshot fidelity cannot be established from the inspected GitHub records.
- Original qualification failure details and rerun authorization were not independently established.
- Signed-device behavior, SDK traffic/signatures, backup/restore and final archive contents require separate evidence.
- Apple/Expo policy currency, field requirements and legal interpretations were not checked because access was restricted to GitHub APIs.
- Store state, name availability, session-authority claims, asset rights and legal acceptance require evidence beyond the inspected implementation.
- Tests run: None. Reviewer execution is disabled.
HemSoft full-spectrum review • 3 evidence-based passes • Reviewed head df191b15aa7279401ae2a4b7939c7dd2ccdf6649 • SFL v0
|
Native phone-5 failed on unchanged df191b1 at scenario flow 5: after Start Game, assertVisible Re-roll (2) failed. Artifact 13206648409 retains the failure screenshot, MCP/recovery logs and save. The screenshot visibly shows Re-roll (2); the retained active game is revision 0 with rollsLeft 2. This supports an observation/timing discrepancy but does not establish the root cause. No tap replay, head or flow changes. Phone-6 passed; tablet jobs remain in progress, so no failed-job rerun has been started. Merge remains held. |
|
@sfl review |
There was a problem hiding this comment.
✅ Verdict: PASS • Round 3
Since round 2
New: 0; still open (repeated): 0; resolved: 1.
Resolved means no matching finding in this review, not independent proof of a fix.
New (0)
- None.
Still open (repeated) (0)
- None.
Resolved (1)
- LOW Correct the repository-root evidence links at
apps/mobile/release/product-page.md:53
Review done by gpt-6.1-sol
Adds version-bound iOS release notes, retained privacy inventory and draft English store metadata. Security, accuracy and quality review found no evidenced defects within the static coverage below; this is not proof of correctness.
🔨 Full-Spectrum Review Summary
Effort: high
Review time: 2m 0s
Token count: Unavailable
| Pass | 🔴 Critical | 🟠 High | 🟡 Medium | ⚪ Low |
|---|---|---|---|---|
| 🔒 Security | 0 | 0 | 0 | 0 |
| ✅ Accuracy | 0 | 0 | 0 | 0 |
| 🧰 Quality & Maintainability | 0 | 0 | 0 | 0 |
| Total | 0 | 0 | 0 | 0 |
Key Findings
No material defects found.
Coverage
- Files reviewed:
History/2026-11-02.mdHistory/2026-11-03.mdapps/mobile/APP-STORE.mdapps/mobile/CHANGELOG.mdapps/mobile/release/candidate.jsonapps/mobile/release/metadata/en-US/description.txtapps/mobile/release/metadata/en-US/listing.jsonapps/mobile/release/metadata/en-US/release_notes.txtapps/mobile/release/metadata/en-US/review_notes.txtapps/mobile/release/notes/1.0.0.mdapps/mobile/release/product-page.mddocs/mobile-privacy-audit.mddocs/privacy/2026-11-02-native.jsonscripts/ios-release/check.mjsscripts/ios-release/check.test.mjsscripts/ios-release/tracker.test.mjs
- Context read:
AGENTS.mdLICENSE.github/workflows/quality.ymlapps/mobile/app.jsonapps/mobile/package.jsonapps/mobile/app/_layout.tsxapps/mobile/native/Podfile.lockapps/mobile/release/screenshots.jsonapps/mobile/release/testflight-notes.mdapps/mobile/src/local/LocalProvider.tsxapps/mobile/src/local/diagnostics.tsapps/mobile/src/local/platformStorage.native.tsapps/mobile/src/local/save.tsapps/mobile/src/local/sqliteStorage.tsapps/mobile/src/local/store.tsapps/mobile/src/screens/Help.tsxapps/mobile/src/screens/History.tsxapps/mobile/src/screens/NativeGameScreen.tsxapps/mobile/src/screens/Setup.tsxapps/mobile/src/support/Support.tsxapps/mobile/src/support/destinations.tspackages/game-engine/src/scoring.tspackages/game-engine/src/session.tspackages/game-engine/src/storage.tspackages/game-engine/tests/nativeSupport.test.tsscripts/ios-native/privacy.mjsscripts/ios-release/evidence.mjsscripts/ios-release/evidence.test.mjssite/pages.mjs
- Verified:
- Compare returned the reserved
base_commit.shaand final commit SHA matching the requested head. - Inspected all 16 changed paths and relevant context at the exact head.
- Security:
versionNotespasses existing relative-path validation and committed-text comparison; draft and approval gates remain. - Security: support URLs encode previewed text; diagnostics use an explicit allowlist; private email and review destinations remain unset.
- Accuracy: native configuration matches candidate version, build and bundle identity.
- Accuracy: setup, session and scoring source support the advertised modes, opponent counts, rerolls and combination rules.
- Accuracy: storage source supports acknowledged saves, unchanged-state retries, damaged-data preservation and documented retention limits.
- Accuracy: retained dependency versions match the mobile package and inspected
PODSentries, includingReactCodegenandReactAppDependencyProvider. - Accuracy: listing field counts match the documented counts; copyright matches
LICENSE. - Accuracy: GitHub run metadata confirms successful Pages deployment at
754d0f9806cf04d6c45b96ebee957cef444c0a17and qualification attempt 2 atdee3455df2f4cb2670008edae66c3e485adbfcba. - Quality: inspected changed regression assertions, release-check callers and existing source-evidence tests.
- Compare returned the reserved
- Not verified:
- Runtime behavior, signed-device qualification, traffic, backup/restore, SDK signatures and store acceptance require evidence outside this static review.
- Historical archive hashes, packaged plist observations and independent inspection receipts were not reproduced; only the committed inventory and inspection implementation were read.
- Historical browser observations, live URL responses, navigation, screenshot appearance and HTTPS enforcement were not independently checked under the GitHub-API-only restriction.
- Apple field requirements, category guidance, accessibility rules and privacy/export interpretations were not independently checked against external references under the GitHub-API-only restriction.
- Historical retry failure causes, owner-authority records, branding provenance and absence of App Store Connect activity were not independently authenticated.
- Underlying SDK behavior and encryption usage were not established by dependency inventories or application source.
- Tests run: None. Reviewer execution is disabled.
HemSoft full-spectrum review • 3 evidence-based passes • Reviewed head 689b6812c7e7c7a0515b22b5933a032ca3cdeb3c • SFL v0

Prepare the iOS 1.0 release records, privacy evidence and English App Store metadata together so they share one strict-base native CI cycle. This combines the corrected commits from #104, #105 and #106 without app-source or flow changes.
Closes #47. Refs #48 and #50; both stay open for the release acceptance work below.
Validation: all 184 combined Node tool/site tests and three support-destination tests pass; draft release checker runs successfully and correctly retains readiness blockers; git diff --check passes. Confirmed the carried privacy and metadata trees match the corrected source branches, all three draft banners remain, and the Pod inventory retains the two previously overwritten versions. Local receipt reports/104-combined-tests.log. Earlier repository typecheck/lint/unit/build/security attempts on these changes failed because the laptop dependency installation is incomplete; they are not claimed passed. Full exact-head CI and SFL PASS remain required before normal merge.
#48 remains open for signed archive/entitlements, SDK signatures, measured device/SDK traffic, backups/restore and supported privacy/export/legal acceptance. The retained package is an unsigned simulator build, not that evidence. #50 remains open for approved public contact information beyond the current GitHub-only route, signed-candidate/device screenshots, app-record setup, final copy review and App Store Connect sync/previews. This session does not access App Store Connect, upload, submit or attest.
Franz explicitly requested combining these three PRs to avoid repeated full native CI cycles. All prior finding fixes are carried forward; original finding threads will be resolved only after this combined head has a clean required review. PRs #105 and #106 are superseded by this PR.
Franz confirmed PR #98 merged on November 3 and released the hold for PR #104, which goes next. Main b902d23 is incorporated. The audit now documents explicit previewed report URLs transmitting allowlisted text to GitHub before an issue is posted; the retained dee3455 package remains historical evidence. Require fresh exact-head SFL PASS, every check green and resolved threads, then normal merge and immediate owner notification so PR #107 can follow. No spending, outreach or app-source changes by this PR.