Skip to content

gh-406: support newer scipy versions#407

Open
ntessore wants to merge 4 commits into
mainfrom
nt/406
Open

gh-406: support newer scipy versions#407
ntessore wants to merge 4 commits into
mainfrom
nt/406

Conversation

@ntessore

Copy link
Copy Markdown
Contributor

Add support for newer scipy versions by importing scipy.special.legendre_p_all() as a drop-in replacement of the deprecated lpn.

Closes: #406

@ntessore ntessore requested a review from JaimeRZP June 16, 2026 13:35
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
py3.10 83.38% <37.50%> (-0.15%) ⬇️
py3.11 83.38% <37.50%> (-0.15%) ⬇️
py3.12 83.34% <37.50%> (-0.15%) ⬇️
py3.13 82.91% <37.50%> (-0.15%) ⬇️
py3.9 83.58% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
heracles/transforms.py 87.50% <100.00%> (+0.46%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JaimeRZP JaimeRZP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

Copilot stopped work on behalf of JaimeRZP due to an error June 18, 2026 15:52
Copilot AI requested a review from JaimeRZP June 18, 2026 15:52
@ntessore

Copy link
Copy Markdown
Contributor Author

Oh, this fails in the last supported scipy for Python 3.9, which is what we need for SGS support. Let me change the PR to support both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run on newer scipy versions

2 participants