Skip to content

fix(producer): dedupe local font embedding by resolved path#2317

Merged
miguel-heygen merged 1 commit into
mainfrom
magi/fix-local-font-canonical-dedupe
Jul 13, 2026
Merged

fix(producer): dedupe local font embedding by resolved path#2317
miguel-heygen merged 1 commit into
mainfrom
magi/fix-local-font-canonical-dedupe

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

Summary

  • cache embedded local fonts by resolved absolute path
  • reuse one data URI across equivalent sub-composition-relative aliases
  • add regression coverage for repeated references to one font file

Reproduction

A composition with three @font-face URLs (assets/shared.woff2, ./assets/shared.woff2, and assets/../assets/shared.woff2) triggered three embed operations before this change. With large TTC assets across sub-compositions, that repeated read/compression caused multi-minute compile stalls.

Verification

  • bun test packages/producer/src/services/htmlCompiler.test.ts (103 pass)
  • bun run --cwd packages/producer typecheck
  • bunx oxfmt --check packages/producer/src/services/htmlCompiler.ts packages/producer/src/services/htmlCompiler.test.ts
  • pre-commit hooks passed (lint, format, fallow, typecheck)

@miguel-heygen
miguel-heygen merged commit 9940503 into main Jul 13, 2026
45 of 46 checks passed
@miguel-heygen
miguel-heygen deleted the magi/fix-local-font-canonical-dedupe branch July 13, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant