Skip to content

fix(engine): resolve root-absolute media from project#2399

Merged
miguel-heygen merged 1 commit into
mainfrom
fix/root-absolute-audio-path-1784005334
Jul 14, 2026
Merged

fix(engine): resolve root-absolute media from project#2399
miguel-heygen merged 1 commit into
mainfrom
fix/root-absolute-audio-path-1784005334

Conversation

@miguel-heygen

@miguel-heygen miguel-heygen commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • resolve browser root-absolute media URLs from the project root
  • preserve explicit absolute filesystem paths when they exist
  • apply identical path semantics to audio mixing and video frame extraction
  • add regression coverage for root-absolute audio and video sources

Root cause

Node classified paths such as /.media/tone.wav as filesystem-absolute, so the audio and video pipelines skipped the project-relative resolver. Browser-served images already interpreted the same path from the project root, creating inconsistent media behavior.

Verification

  • 13 audio mixer tests passed
  • 9 focused media resolver tests passed
  • engine typecheck passed
  • formatting and lint passed
  • end-to-end fixture changed from video-only to video plus audio
  • full video extractor suite had 79 passing tests and 2 unrelated failures because the environment FFmpeg lacks -fps_mode

@miguel-heygen
miguel-heygen merged commit 6fc9230 into main Jul 14, 2026
47 of 68 checks passed
@miguel-heygen
miguel-heygen deleted the fix/root-absolute-audio-path-1784005334 branch July 14, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant