Skip to content

test(engine): make FFmpeg path assertion cross-platform#2433

Merged
miguel-heygen merged 1 commit into
mainfrom
fix/windows-ffmpeg-path-test
Jul 14, 2026
Merged

test(engine): make FFmpeg path assertion cross-platform#2433
miguel-heygen merged 1 commit into
mainfrom
fix/windows-ffmpeg-path-test

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

Summary

PR #2430 merged before Windows render verification completed. Its new FFmpeg diagnostic test expected the POSIX path /tools/ffmpeg.exe, while the Windows runner correctly rendered D:\tools\ffmpeg.exe, causing both DLL-not-found exit-code cases to fail. The assertion now compares against Node's platform-resolved path; production behavior is unchanged.

Test plan

  • bun run --cwd packages/engine test -- src/utils/runFfmpeg.test.ts
  • bunx oxfmt --check packages/engine/src/utils/runFfmpeg.test.ts

Compound Engineering
Codex

@miguel-heygen
miguel-heygen merged commit d7204ac into main Jul 14, 2026
46 checks passed
@miguel-heygen
miguel-heygen deleted the fix/windows-ffmpeg-path-test branch July 14, 2026 17:22

@miguel-heygen miguel-heygen left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge advisory review (this PR is already merged into main). Findings flagged for follow-up, not gating.

The revised assertion at packages/engine/src/utils/runFfmpeg.test.ts:73 correctly mirrors the native path.resolve() contract used by getConfiguredBinary() at packages/engine/src/utils/ffmpegBinaries.ts:85-88. It preserves the full selected-path assertion across POSIX and Windows drive/separator semantics rather than weakening it to a basename. The adjacent spawn test at packages/engine/src/utils/runFfmpeg.test.ts:107-118 independently pins the same resolved path at the process boundary.

Fresh context-isolated adversarial pass: I checked relative paths, dot normalization, drive-qualified paths, mixed separators, UNC paths, the process.platform mock interaction, the originating Windows failure log, and the exact-head Windows check. No follow-up findings.

Focused verification: bun run --cwd packages/engine test -- src/utils/runFfmpeg.test.ts (10/10) and bunx oxfmt --check packages/engine/src/utils/runFfmpeg.test.ts passed. Exact-head CI completed with no failures, including Tests on windows-latest.

Verdict: COMMENT (post-merge: Ready)
Reasoning: The one-line change accurately follows production's native Node path-resolution behavior and retains meaningful coverage; exact-head CI and focused local tests are green.

— Deepwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant