revert(producer): drop renderStretch fit_to_scene retime (#2676)#2730
Merged
Conversation
vanceingalls
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2676 (
renderStretch).Why
renderStretchtried to fix thefit_to_scenestutter (a composition shorter than its scene is frame-held by the compositor) by re-timing the GSAP timeline at render: emit target-length output and scale the per-frame seek across[0, intrinsic]. Local render tests show this cannot work — seeking a 1s-authored timeline more finely does not create new motion. The extra output frames are near-duplicates of their neighbours (sub-pixel deltas collapse on capture), so a 1s composition still yields ~30 distinct frames regardless ofrenderStretch. Measured: a 1s composition renders 30 unique frames at 30fps and stays ~30 unique underrenderStretch; only 118 unique at a native 120fps render.What replaces it
The correct fix needs no producer change: the producer already honours the
fpsoverride, and rendering a short composition at a scene-scaled fps (ceil(output_fps * scene / intrinsic)) produces genuinely distinct frames that fill the stretched clip. That lives entirely in experiment-framework (#42766) — it computes the fps and passes it through the existingfpsfield. NorenderStretchplumbing required.Ref: VA-1859.