fix(cli): reject unsupported MP4 encoders#2735
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MP4 renders now stop at capability preflight when the selected FFmpeg build has neither
libx264nor the supported VideoToolbox fallback. Previously, the CLI treated this definitive capability result as advisory and continued until the encoder rejected-x264-params; users now get both a distro-aware install command and an actionable--format webmalternative before frame capture starts. Inconclusive probe failures remain advisory, and the existing VideoToolbox fallback is unchanged.Authorized originating source: https://slack.com/archives/C0BGC335AQY/p1784695521573939
Test plan
bun run --cwd packages/cli test -- src/browser/ffmpeg.test.ts src/commands/render.test.ts(75 passed)bun run --cwd packages/cli typecheckbunx oxlintandbunx oxfmt --checkon changed filesbun run buildx264-params, producer pipeline, or MP4 output