fix(studio): keep preview selection overlay visible while element selected - #785
Closed
Jefsky wants to merge 1 commit into
Closed
fix(studio): keep preview selection overlay visible while element selected#785Jefsky wants to merge 1 commit into
Jefsky wants to merge 1 commit into
Conversation
…ected The selection overlay was hidden whenever the selected timeline element was not active at the current playback time (isTimelineElementActiveAtTime check). This caused the overlay to flicker/disappear during playback for elements that don't span the playhead position. Now the overlay stays visible whenever an element is selected and the inspector panel is open, regardless of playback state. Fixes heygen-com#777
Collaborator
|
I merged a pr addressing the same thing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The selection overlay in the Studio preview was disappearing even while an element remained selected, because its visibility was tied to the element being active at the current playback time. This caused the overlay to flicker/disappear during playback.
What changed
packages/studio/src/App.tsx - shouldShowSelectedDomBounds now checks selectedTimelineElement != null instead of also requiring the element to be timeline-active. The overlay stays visible whenever something is selected and the inspector panel is open.
Closes #777