Repository navigation
Keep atomized reference in _updateSnapshotStorage - #910
Merged
lejeunerenard merged 1 commit intoOct 28, 2026
Merged
Conversation
lejeunerenard
approved these changes
Oct 28, 2026
lejeunerenard
left a comment
lejeunerenard
left a comment
Contributor
There was a problem hiding this comment.
Great! Nice and simple fix and the scenario makes sense now. Thank you for the repo before and the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #892.
SessionState.close()setsparent.atomized = null, so closing an atomic session while a snapshot of its parent waits in_updateSnapshotStoragethrowsTypeError: Cannot read properties of null (reading 'flushing')on the next loop check. Holdingthis.atomizedin a local fixes it.Adds a regression test in
test/atomic.jsbuilt from the repro in the issue. It crashes without the change; the full suite passes with it (445/445).