[shubhamkapoor01]

After a session closes, its extension handlers still fire for peers that were already connected. _close set opened = false before destroying the extensions, so session.peers was empty and nothing was removed. This runs the cleanup before that, with a test.

Fixes #905

[greptile-apps]

Confidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

Moves extension cleanup before the session clears opened, so destroy() can still reach connected peers.

• Closing a session removes its extensions from connected peers.

_{Reviews (1) · Last reviewed commit: "Add note about why `.opened` must be bel..." · Reviewed by Greptile}

[lejeunerenard]

Great thanks! That's a subtle bug, so thanks for finding it.

Btw if you are using extensions, its generally recommended to use protomux channels instead. Extensions predate protomux and it's a cleaner separation of concerns. Ad hoc messaging protocols are better implemented with it so that you aren't required to have a hypercore replication stream.

Thanks again!