Skip to content

docs(claude): never merge a PR without the owner's explicit approval #50

Closed

Description

@homer6

PRs #19, #38, #42 and #49 were merged straight after opening, without the owner's approval for each. CLAUDE.md → "Syncing and merging" should say: never merge a PR without the owner's explicit verdict for that PR (e.g. "merge #n", or "merge them all" naming the batch) — including CLAUDE.md/README PRs opened at the owner's request. Opening the PR and closing its issue is the end of the work; PRs then go through review (/review-prs).

Acceptance: the rule is in CLAUDE.md and the refresh-guidelines skill's delivery section.

Activity

  1. self-assigned this
    on Oct 31, 2026
  2. homer6 commented on Oct 31, 2026

    @homer6
    OwnerAuthor

    Delivered in #51 (open for review — not merged).

    What changed

    • CLAUDE.md → Syncing and merging: new rule — never merge a PR without the owner's explicit approval for that PR ("merge #n" or a named batch); being asked for a change means open the PR and close its issue, not merge; batch approval doesn't carry over; review via /review-prs.
    • .claude/skills/refresh-guidelines/SKILL.md: the Merge step says the same.

    Why

    Still open

    • This PR waits for the owner's verdict.
  3. homer6 commented on Oct 31, 2026

    @homer6
    OwnerAuthor

    Merged in #51 (aafe515) on the owner's review.

    What changed

    • Nothing since the PR was opened; no rebase was needed.

    Why

    • Approved by the owner.

    Still open

    • Nothing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions