Repository navigation
docs(security): verify the deployment page - #335
Merged
Merged
Conversation
This was referenced Nov 3, 2026
homer6
force-pushed
the
security/302-supply-chain
branch
from
November 3, 2026 12:23
c1e47ed to
fd06784
Compare
homer6
force-pushed
the
security/303-deployment
branch
from
November 3, 2026 12:23
5c41754 to
c461029
Compare
homer6
force-pushed
the
security/303-deployment
branch
from
November 3, 2026 13:37
c461029 to
9779141
Compare
Owner
Author
|
Rebased onto
|
This was referenced Nov 3, 2026
Under the owner's rule that guidance beyond C++ belongs when it changes how the C++ is written: stop safely and restart cleanly (supervisor with a rate limit, write-to-temp-then-rename so a crash never leaves half a file, with a tested write_atomically), and get secrets at run time (a secret store, never argv, prefer files to environment variables, read once, plan for rotation). Related to #303
Owner
Author
|
Merged into
|
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/security/deployment.mdis rewritten and verified. As the issue asked, it keeps to the C++-relevant parts: privilege separation, sandboxing parsers, crash reports without secrets, and logs.drop_privileges()drops in the order CERT POS36-C requires (groups → gid → uid), checks every result and confirms root can't be regained (POS37-C). Plus capabilities, socket activation and service accounts.no_new_privs, Landlock, Capsicum, pledge/unveil, App Sandbox, AppContainer). seccomp strict mode's four system calls and theno_new_privsrequirement are from seccomp(2). Includes aforbid_new_privileges()snippet.PR_SET_DUMPABLE(also blocks same-user ptrace; thesuid_dumpable=2caveat);MADV_DONTDUMP(Linux 3.4+);RLIMIT_CORE, which core(5) says isn't enforced when dumps are piped to a handler such as systemd-coredump, so it isn't relied on alone;Secrettype that formats and streams as[redacted], andlog_field(), which escapes control characters against log forging and terminal escapes (CWE-117).SECURITY.md/ GitHub private reporting, and a "ship" process that means a rebuilt binary. Every report becomes a regression test.tests/security/deployment_test.cpp:std::formatand<<;RLIMIT_COREcan be lowered;MADV_DONTDUMP, andno_new_privsis one-way (checked in a child process).cpp-securityskill page table row updated.README/CLAUDE.md: no change needed.
Still open (owner decision): the repo has no
SECURITY.md. The page recommends one, but it needs a contact the owner chooses.Related
Test plan
gcc:16image, arm64), whole security binary:FailedDropThrowsskipped (root);check_snippets.py docs/security/deployment.md: 5/5 on GCC 15, Clang 22 and Linux GCC 16. The Linux-guarded blocks are actually compiled there.run_clang_tidy.shon the new test: no findings.