fix(core): omit TCP defaults for Unix-socket SQL config#209
Open
TDannhauer wants to merge 1 commit into
Open
Conversation
Core#198 preserved protocol/socket keys but still injected host=localhost and port=3306. PDO strips protocol from the DSN, so socket PostgreSQL deployments still dial MySQL's port and fail (e.g. smartmobile portal Token/PermissionService for non-admins).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DbServiceFactoryfrom injectinghost=localhost/port=3306when SQLprotocol=unix.Motivation
Follow-up to #198. That change preserved
protocol/socketkeys, but still always set TCP host/port defaults. PDO adapters stripprotocolwhen building the DSN, so socket-based PostgreSQL deployments still attemptedlocalhost:3306and failed with connection refused.This showed up after smartmobile login for non-admin users: the modern portal resolves SQL-backed
Token/PermissionServiceviaDbServiceFactory. Admins / legacy app entry points often avoided that path.Changes
buildConnectionConfig(): forprotocol=unix, only pass host/port when explicitly configured.pgsql, 3306 otherwise.Test plan
vendor/bin/phpunit -c vendor/horde/core/phpunit.xml.dist --bootstrap vendor/autoload.php vendor/horde/core/test/Unit/Factory/DbServiceFactoryTest.php