Port generate-encoding-data.py to Python 3 - #124
Merged
Merged
Conversation
This was done with 2to3 version 3.11.2-1 installed from Debian bookworm. 2to3 is an automated source code translator for upgrading python2 scripts to python 3.
The previous commit hash, 1d519bf8e5555cef64cf3a712485f41cd1a6a990, was part of PR whatwg/encoding#336, and eventually got merged as commit 2c3853e461afd718be198772170d024e427aee21. There is only a mild change between these two commits, where wording in encoding.bs was changed.
Note that Python 3's open() function defaults to a platform dependent encoding (locale.getencoding()), which is not what we want!
Contributor
Author
|
Drafting while I investigate what's going on in the generated codepage/{lib,test}.rs, which wants to add two encodings + assert_eq!(to_encoding(10007), Some(X_MAC_CYRILLIC));
+ assert_eq!(to_encoding(21010), Some(UTF_16LE));EDIT: These seem to be correct, which would just make the 10007: "x-mac-cyrillic",
21010: "UTF-16LE", # Undocumented; needed by calamine for Excel compatEDIT 2: These two's absence is issue #70. |
Nopey
marked this pull request as draft
August 3, 2025 05:38
Nopey
marked this pull request as ready for review
August 3, 2025 05:41
Owner
|
Excellent! Thank you. (I previously gave up at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No changes to the generated files, as those still generate the same.