Skip to content

Proposal: Refactor Middleware Execution / Next with Cursors and Async Recursion #896

Open

Description

@nyxtom

I recently came across the salvo implementation for middleware (control flow) and I really like the use of the async_recursion combined with a simple cursor to allow middleware to run without any additional lifetimes. I think we could probably clean up the middleware to do something similar possibly.

    /// Call next handler. If get next handler and executed, returns true, otherwise returns false.
    ///
    /// If resposne's statuse code is error or is redirection, all reset handlers will skipped.
    #[inline]
    #[async_recursion]
    pub async fn call_next(&mut self, req: &mut Request, depot: &mut Depot, res: &mut Response) -> bool {
        if let Some(code) = res.status_code() {
            if code.is_client_error() || code.is_server_error() || code.is_redirection() {
                self.skip_rest();
                return false;
            }
        }
        if let Some(handler) = self.handlers.get(self.cursor) {
            self.cursor += 1;
            handler.clone().handle(req, depot, res, self).await;
            if self.has_next() {
                self.call_next(req, depot, res).await;
            }
            true
        } else {
            false
        }
    }

Activity

  1. nyxtom commented on Jul 16, 2022

    @nyxtom
    ContributorAuthor

    My current implementation #895 solves this issue by eliminating the need for both <State> on the Request as well as removing the for<'a> requirements on middleware. This allows us to use just Next and Request. I've implemented a simple cursor step process and the use of Arcs to solve this issue. This also solves the issue of having closures #854

  2. reopened this on Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions