You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Proposal: Refactor Middleware Execution / Next with Cursors and Async Recursion #896
I recently came across the salvo implementation for middleware (control flow) and I really like the use of the async_recursion combined with a simple cursor to allow middleware to run without any additional lifetimes. I think we could probably clean up the middleware to do something similar possibly.
/// Call next handler. If get next handler and executed, returns true, otherwise returns false.////// If resposne's statuse code is error or is redirection, all reset handlers will skipped.#[inline]#[async_recursion]pubasyncfncall_next(&mutself,req:&mutRequest,depot:&mutDepot,res:&mutResponse) -> bool{ifletSome(code) = res.status_code(){if code.is_client_error() || code.is_server_error() || code.is_redirection(){self.skip_rest();returnfalse;}}ifletSome(handler) = self.handlers.get(self.cursor){self.cursor += 1;
handler.clone().handle(req, depot, res,self).await;ifself.has_next(){self.call_next(req, depot, res).await;}true}else{false}}
My current implementation #895 solves this issue by eliminating the need for both <State> on the Request as well as removing the for<'a> requirements on middleware. This allows us to use just Next and Request. I've implemented a simple cursor step process and the use of Arcs to solve this issue. This also solves the issue of having closures #854
Activity
nyxtom commentedon Jul 16, 2022
My current implementation #895 solves this issue by eliminating the need for both
<State>on theRequestas well as removing thefor<'a>requirements on middleware. This allows us to use justNextandRequest. I've implemented a simple cursor step process and the use of Arcs to solve this issue. This also solves the issue of having closures #854