Fix logging logic when in_order is set to True#3280
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
CI is failing because of the |
|
@BenjaminBossan |
muellerzr
left a comment
There was a problem hiding this comment.
Thanks! Overall this looks good to me, however there's logger-related tests which are now failing. Can you modify those tests since our logs differ a bit now?
|
@muellerzr I've tried to fix the tests. Would you please take a look. Thanks! |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
SunMarc
left a comment
There was a problem hiding this comment.
Thanks ! Sorry that this didn't get merged in time
|
@bot /style |
|
Style bot fixed some files and pushed the changes. |
What does this PR do?
This PR fix the logging logic when
in_orderis set toTrue. Right now, thein_orderflag either hangs the program whenmain_process_onlyis also set toTrue, or does nothing whenmain_process_onlyis set toFalse.A simple code snippet to test (run with
accelerate launch --num_processes=2 test.py):Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.