remove use_xpu to fix ut issues, we don't need this since XPU is OOB …#3460
Merged
Conversation
…supported now Signed-off-by: Yao, Matrix <matrix.yao@intel.com>
Contributor
Author
Contributor
Author
|
@faaany , since it changes the default behavior, could you help run accelerate UTs for this? Thx |
Contributor
sure |
Contributor
|
@yao-matrix no test error is found related to this PR. |
Contributor
Author
|
@SunMarc @muellerzr , pls help review, thx. |
muellerzr
reviewed
Mar 31, 2025
Contributor
muellerzr
left a comment
There was a problem hiding this comment.
Overall on the surface: good. But let's be careful to deprecate please!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Signed-off-by: YAO Matrix <matrix.yao@intel.com>
Contributor
Author
|
@muellerzr @SunMarc, updated per your comments. Pls help review whether any other changes needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sympton
When run transformers e2e training ut
pytest -rA tests/trainer/test_trainer.py::TrainerIntegrationTest::test_end_to_end_exampleon XPU, we will get below error:Root Cause
When run this test case while there is no default accelerate config in “/root/.cache/huggingface/accelerate/default_config.yaml”(generated by
accelerate config), theuse_xpuflag inlaunch.py(default False) blocked the using of XPU, so accelerate is launched both in single process and in cpu, but when data comes, it automatically detected xpu and put data into xpu, so model is in cpu and data is in xpu, lead to this error.Fix
XPU is now native citizen of PyTorch, we need align the same behavior w/ CUDA, so remove these special handling.