Skip to content

TST Add test for FSDP ignored_modules as str#3719

Merged
SunMarc merged 1 commit into
huggingface:mainfrom
BenjaminBossan:tst-fsdp-ignored-modules
Aug 6, 2025
Merged

TST Add test for FSDP ignored_modules as str#3719
SunMarc merged 1 commit into
huggingface:mainfrom
BenjaminBossan:tst-fsdp-ignored-modules

Conversation

@BenjaminBossan
Copy link
Copy Markdown
Member

What does this PR do?

Follow up to #3698.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot !

@SunMarc SunMarc merged commit e23b004 into huggingface:main Aug 6, 2025
25 checks passed
@BenjaminBossan BenjaminBossan deleted the tst-fsdp-ignored-modules branch August 6, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants