Fix stateful dataloader DDP #3952
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3938. The tests we had didn't catch the issue that the user was having, so i changed it. Here's the summary of the changes:
its own sharded iterator with a single 1-batch look-ahead)
Root cause
In DataLoaderShard.iter, _update_state_dict() is called before the inner next(), so the captured state already equals the number of batches yielded to the user — no DDP adjustment is needed. The base class adjustment of num_processes - 1 caused the resume point to be 1 batch too early, producing duplicate data.
The bug only affects map-style datasets with use_stateful_dataloader=True in multi-process DDP. Iterable datasets were unaffected because their _sampler_iter_state provides correct resume info independently of _num_yielded. The previous tests didn't catch this because they (a) only used iterable datasets, (b) saved state at the second-to-last batch leaving only 1 batch remaining, and (c) used zip without a length check.