Skip to content
This repository was archived by the owner on Nov 21, 2026. It is now read-only.
This repository was archived by the owner on Nov 21, 2026. It is now read-only.

bindings: address CodeRabbit's review of upstream PR #9294 (wheel selection in build.sh, three examples, exporter message, xfail count) #264

Closed

Description

@tae898

CodeRabbit reviewed our upstream PR ArcadeData#9294 (the python-bindings branch) on 2026-10-06 with seven actionable comments, and none were answered: the upstream watcher filtered bot reviews until today. All seven are in our code, so the fixes land here first and reach ArcadeData#9294 when the branch is regenerated.

  • bindings/python/scripts/build.sh (Major): after a fully cached Docker build, docker cp keeps the container's mtime, so ls -t can rank another build's wheel first and the cleanup deletes the wheel just produced as superseded. Take the wheel this run added (NEW_WHEELS).
  • build.sh (Minor): the jar-hash check picks its wheel by mtime and checks the version against DOCKER_TAG; use NEW_WHEELS, and BUILD_VERSION when set.
  • examples/24_server_http_transactions_timeseries.py: --server-root is deleted with rmtree without warning; refuse a non-empty user directory.
  • examples/scripts/compare_query_hashes.py: a malformed result line is dropped and the comparison passes on the rest; fail on it.
  • examples/17_timeseries_end_to_end.py: the server-mode demo raises on a runtime without the server part, after the embedded part succeeded; skip it with a message. (samples itself is always defined there: the early return exits first.)
  • src/arcadedb_embedded/exporter.py: the "needs arcadedb-gremlin" explanation fires on any "not found"; limit it to GraphML and GraphSON.
  • .github/workflows/test-python-bindings.yml: count only <skipped type="pytest.xfail"> as expected failures (a tightening; modern pytest writes that type only there).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions