This repository was archived by the owner on Nov 21, 2026. It is now read-only.
Repository navigation
bindings: one-way edge refusal and query contract (#8625), warm_up() for the vector index (#8852) (#87) - #88
Merged
Merged
Conversation
…warm_up() for the vector index (ArcadeData#8852) (#87) ArcadeData#8625 (fixed in ArcadeData#8628, in 26.10.1): graph_batch with bidirectional=False on an edge type declared two-way is now refused, new_edge raising ArcadeDBError naming the type, and nothing is written. The docs and the graph_batch() docstring said the batch does not check; they now say refusal. docs/guide/graphs.md gains the one-way query contract, each claim checked on the synced wheel: patterns (Cypher from either end and undirected, SQL MATCH) see every edge; in(), inE(), both(), bothE(), and the target's get_in_edges() see none; out() and get_out_edges() on the source see them all. ArcadeData#8852 (fixed in ArcadeData#8863): VectorIndex.warm_up() calls LSMVectorIndex.warmUp() on every underlying index, loading the persisted graph now instead of on the first search; ArcadeDBError on an engine without it. Documented in the API and the guide beside the throwaway search, whose example wraps the vector in a list (a lone list argument is the parameter list). Tests, on the synced engine 802233c (wheel built from its image's jars) and against arcadedb-embedded==26.9.1, where all three fail for the right reason: test_graph_batch_refuses_one_way_edges_in_a_two_way_type (26.9.1 accepts the edge), test_one_way_edges_are_seen_by_patterns_not_by_in (26.9.1's incoming Cypher pattern counts 0 of 100), and test_warm_up_loads_the_persisted_graph_before_the_first_search (graphState 0 and graphNodeCount 0 after the reopen, all 2,000 nodes resident after warm_up; 26.9.1 has no warm_up). Full suite 492 passed, 3 skipped; bandit at low/low and pre-commit clean. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lj5isEaoaGCeaZe5nNoWX4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87.
graph_batch(bidirectional=False)on an edge type declared two-way is refused (new_edgeraisesArcadeDBErrornaming the type, nothing written).docs/guide/graphs.md,docs/api/graph_batch.md, and thegraph_batch()docstring now say refusal, not silent loss.docs/guide/graphs.md, each claim checked on the synced wheel: Cypher (from either end and undirected) and SQLMATCHsee every edge of aUNIDIRECTIONALtype;in(),inE(),both(),bothE(), and the target'sget_in_edges()see none;out()and the source'sget_out_edges()see all.VectorIndex.warm_up()callsLSMVectorIndex.warmUp()on every underlying index, loading the persisted graph before the first search;ArcadeDBErroron an older engine. Documented in the API and the guide beside the throwaway search.Tests: three new ones, run on the synced engine
802233cb57(wheel built from its image's jars) and againstarcadedb-embedded==26.9.1, where all three fail for the right reason (the edge is accepted; the incoming Cypher pattern counts 0 of 100; nowarm_up). Full suite 492 passed, 3 skipped; bandit at low/low and pre-commit clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01Lj5isEaoaGCeaZe5nNoWX4