Repository navigation
CI: add st-a5 and st-sim-a5 DFX per-feature smoke steps. - #1278
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughFour new pytest smoke-test steps (dep_gen, l2_swimlane, PMU, args_dump) were added to the st-sim-a5 job in the CI workflow, mirroring the existing st-sim-a2a3 coverage with corresponding --enable-* flags and platform/device settings. ChangesCI Smoke Coverage
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c2a26fd to
0a28d23
Compare
d9861a9 to
e00c1b7
Compare
e00c1b7 to
ff475e7
Compare
…m L2 swimlane rotation table and finalize collectors Fixes hw-native-sys#1249 The a2a3/a2a3sim job already runs four dedicated DFX smoke steps (dep_gen, l2_swimlane, PMU, args_dump) with the matching --enable-* flags. The a5/a5sim job only ran the default pytest sweep, so a5 DFX scene tests were collected but their capture pipelines were never validated in sim CI. Mirror the st-a2a3/st-sim-a2a3 smoke set in st-a5/st-sim-a5 with a5/a5sim paths and flags. graphviz is already installed in the a5/a5sim job for dep_gen. Items A.1-A.3 (PMU artifact validation hardening in test_pmu.py) were already landed on main; this commit closes the remaining sim CI gap. Also update a5's DeviceRunner::finalize_collectors() to use finalize() instead of stop() for diagnostics collectors, matching a2a3's implementation. This ensures shared memory is properly released on any exit from run() — success or early error — preventing stale state issues when workers are reused across runs (e.g., pytest session-scoped worker pool). Add scope_stats_collector_ cleanup with args.scope_stats_data_base reset. a5 sim DeviceRunner never published l2_swimlane_aicore_rotation_table to the AICPU .so, so AICPU init could not fill per-core head slots and get_l2_swimlane_aicore_head() returned null → segfault in record_task. Also replace stop-only perf_cleanup with finalize_collectors(), matching a2a3 sim and the onboard fix, so session-scoped Workers can re-init DFX collectors across runs.
…m L2 swimlane rotation table and finalize collectors (hw-native-sys#1278) Fixes hw-native-sys#1249 The a2a3/a2a3sim job already runs four dedicated DFX smoke steps (dep_gen, l2_swimlane, PMU, args_dump) with the matching --enable-* flags. The a5/a5sim job only ran the default pytest sweep, so a5 DFX scene tests were collected but their capture pipelines were never validated in sim CI. Mirror the st-a2a3/st-sim-a2a3 smoke set in st-a5/st-sim-a5 with a5/a5sim paths and flags. graphviz is already installed in the a5/a5sim job for dep_gen. Items A.1-A.3 (PMU artifact validation hardening in test_pmu.py) were already landed on main; this commit closes the remaining sim CI gap. Also update a5's DeviceRunner::finalize_collectors() to use finalize() instead of stop() for diagnostics collectors, matching a2a3's implementation. This ensures shared memory is properly released on any exit from run() — success or early error — preventing stale state issues when workers are reused across runs (e.g., pytest session-scoped worker pool). Add scope_stats_collector_ cleanup with args.scope_stats_data_base reset. a5 sim DeviceRunner never published l2_swimlane_aicore_rotation_table to the AICPU .so, so AICPU init could not fill per-core head slots and get_l2_swimlane_aicore_head() returned null → segfault in record_task. Also replace stop-only perf_cleanup with finalize_collectors(), matching a2a3 sim and the onboard fix, so session-scoped Workers can re-init DFX collectors across runs.
Fixes #1249
The a2a3/a2a3sim job already runs four dedicated DFX smoke steps (dep_gen, l2_swimlane, PMU, args_dump) with the matching --enable-* flags. The a5/a5sim job only ran the default pytest sweep, so a5 DFX scene tests were collected but their capture pipelines were never validated in sim CI.
Mirror the st-a2a3/st-sim-a2a3 smoke set in st-a5/st-sim-a5 with a5/a5sim paths and flags. graphviz is already installed in the a5/a5sim job for dep_gen.
Items A.1-A.3 (PMU artifact validation hardening in test_pmu.py) were already landed on main; this commit closes the remaining sim CI gap.
Also update a5's DeviceRunner::finalize_collectors() to use finalize() instead of stop() for diagnostics collectors, matching a2a3's implementation. This ensures shared memory is properly released on any exit from run() — success or early error — preventing stale state issues when workers are reused across runs (e.g., pytest session-scoped worker pool). Add scope_stats_collector_ cleanup with args.scope_stats_data_base reset.