Skip to content

feat: add support for optional tyoe usage in schema #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaron-steinfeld merged 1 commit into from
May 25, 2021
Merged

feat: add support for optional tyoe usage in schema #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hypertrace-core-graphql-deserialization/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ dependencies {
compileOnly("org.projectlombok:lombok")

implementation("com.fasterxml.jackson.datatype:jackson-datatype-jsr310")
implementation("com.fasterxml.jackson.datatype:jackson-datatype-jdk8")
implementation("org.slf4j:slf4j-api")

testImplementation("org.junit.jupiter:junit-jupiter")
Expand Down
4 changes: 3 additions & 1 deletion ...rc/main/java/org/hypertrace/core/graphql/deserialization/DefaultArgumentDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import com.fasterxml.jackson.databind.Module;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.json.JsonMapper;
import com.fasterxml.jackson.datatype.jdk8.Jdk8Module;
import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
import java.util.Collection;
import java.util.List;
Expand All @@ -20,7 +21,8 @@

class DefaultArgumentDeserializer implements ArgumentDeserializer {

private static final List<Module> defaultModules = List.of(new JavaTimeModule());
private static final List<Module> defaultModules =
List.of(new JavaTimeModule(), new Jdk8Module());
private static final Logger LOG = LoggerFactory.getLogger(DefaultArgumentDeserializer.class);

private final ObjectMapper objectMapper;
Expand Down
5 changes: 3 additions & 2 deletions hypertrace-core-graphql-platform/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ dependencies {
api("io.grpc:grpc-core:1.36.0")
api("io.grpc:grpc-stub:1.36.0")
api("io.grpc:grpc-context:1.36.0")
api("com.fasterxml.jackson.core:jackson-databind:2.12.1")
api("com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.12.1")
api("com.fasterxml.jackson.core:jackson-databind:2.12.3")
api("com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.12.3")
api("com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.12.3")
api("org.apache.commons:commons-text:1.9")
api("io.opentelemetry:opentelemetry-proto:1.1.0-alpha")

Expand Down