Skip to content

AVGRATE changes - #110

Merged
sarthak77 merged 4 commits into
mainfrom
avgrate-changes
Nov 1, 2021
Merged

AVGRATE changes #110
sarthak77 merged 4 commits into
mainfrom
avgrate-changes

Conversation

@sarthak77

@sarthak77 sarthak77 commented Oct 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

@sarthak77
sarthak77 requested a review from a team as a code owner October 29, 2021 08:00
@codecov

codecov Bot commented Oct 29, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #110 (321c08d) into main (ce318ae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #110   +/-   ##
=========================================
  Coverage     22.98%   22.98%           
  Complexity       75       75           
=========================================
  Files            65       65           
  Lines          1679     1679           
  Branches         52       52           
=========================================
  Hits            386      386           
  Misses         1284     1284           
  Partials          9        9
Flag Coverage Δ
unit 22.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce318ae...321c08d. Read the comment docs.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
aaron-steinfeld
aaron-steinfeld requested changes Oct 29, 2021
View reviewed changes

@aaron-steinfeld aaron-steinfeld left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a revert of the core module. I thought we verified that on build, let me go check that..

@aaron-steinfeld

aaron-steinfeld commented Oct 29, 2021

Copy link
Copy Markdown
Contributor

We don't verify it. Our normal check( which is missing also and I will add) verifies that it's on main, which wouldn't have caught this. I forgot we don't enforce that it doesn't move backwards since that would prevent reverting.

@kotharironak

kotharironak commented Nov 1, 2021

Copy link
Copy Markdown
Contributor

@sarthak77 there are some conflicts on hypetrace-core-graphql, can you retry updating sub-module?

@github-actions

This comment has been minimized.

Sign in to view
@sarthak77
sarthak77 merged commit ed9fa50 into main Nov 1, 2021
@sarthak77
sarthak77 deleted the avgrate-changes branch November 1, 2021 17:41
@github-actions

github-actions Bot commented Nov 1, 2021

Copy link
Copy Markdown

Unit Test Results

11 files  ±0  11 suites  ±0   18s ⏱️ +2s
24 tests ±0  24 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ed9fa50. ± Comparison against base commit ce318ae.

skjindal93 pushed a commit that referenced this pull request Jun 21, 2024
@SrikarMannepalli
feat: Add DISTINCT_ARRAY aggregation type (#110)
3584f91 
* feat: add distinct aggregation

* add DISTINCT_ARRAY operator

* update attribute service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaron-steinfeld aaron-steinfeld aaron-steinfeld approved these changes
@kotharironak kotharironak Awaiting requested review from kotharironak

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarthak77 @aaron-steinfeld @kotharironak