Repository navigation
fix: log and skip if entity can't be joined - #95
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
============================================
+ Coverage 22.10% 22.18% +0.07%
- Complexity 66 67 +1
============================================
Files 64 64
Lines 1606 1614 +8
Branches 49 50 +1
============================================
+ Hits 355 358 +3
- Misses 1244 1248 +4
- Partials 7 8 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tim-mwangi
approved these changes
Aug 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the case of a dangling reference, while it is an error we want to degrade gracefully and return other results. This allows skipping the bad reference and logging it as an error without throwing out the whole request.
Testing
Manual verification, reran UTs