Skip to content

fix: log and skip if entity can't be joined - #95

Merged
aaron-steinfeld merged 1 commit into
mainfrom
entity-join-log
Aug 17, 2021
Merged

aaron-steinfeld merged 1 commit into
mainfrom
entity-join-log

Conversation

@aaron-steinfeld

Copy link
Copy Markdown
Contributor

Description

In the case of a dangling reference, while it is an error we want to degrade gracefully and return other results. This allows skipping the bad reference and logging it as an error without throwing out the whole request.

Testing

Manual verification, reran UTs

@aaron-steinfeld
aaron-steinfeld requested a review from a team as a code owner August 17, 2021 17:44
@github-actions

This comment has been minimized.

@codecov

codecov Bot commented Aug 17, 2021

Copy link
Copy Markdown

Codecov Report

Merging #95 (f26878d) into main (0f60667) will increase coverage by 0.07%.
The diff coverage is 37.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #95      +/-   ##
============================================
+ Coverage     22.10%   22.18%   +0.07%     
- Complexity       66       67       +1     
============================================
  Files            64       64              
  Lines          1606     1614       +8     
  Branches         49       50       +1     
============================================
+ Hits            355      358       +3     
- Misses         1244     1248       +4     
- Partials          7        8       +1     
Flag Coverage Δ
unit 22.18% <37.50%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...phql/entity/joiner/DefaultEntityJoinerBuilder.java 89.09% <37.50%> (-4.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f60667...f26878d. Read the comment docs.

@aaron-steinfeld
aaron-steinfeld merged commit 2ec9f99 into main Aug 17, 2021
@aaron-steinfeld
aaron-steinfeld deleted the entity-join-log branch August 17, 2021 19:55
@github-actions

Copy link
Copy Markdown

Unit Test Results

10 files  ±0  10 suites  ±0   11s ⏱️ -3s
20 tests ±0  20 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2ec9f99. ± Comparison against base commit 0f60667.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants