Repository navigation
Instruct dialog replies instead of cutting them; translate with our LLM - #260
Merged
Merged
Conversation
Reply shape: the deterministic cutting of reaction openers, read-back quotes and unstarted promises is gone. The model is told to start with the substance instead: the last-message note now asks for a first sentence without a reaction to the message, its rating or the person's name. The guard only re-samples once for an opening repeated from the last eight replies or a generation announced without a call. Rates: the `$` / `;` command is the deterministic table handler again. A rates request in conversation calls currency_rates, which now sends the same table as the reply and ends the turn. Draw API: the `%` shortcut and the draw_api tool work for global admins only; others are pointed to draw_image. Translation: translate_text calls the routed `translation` workflow (migration 207: GPU0 Gemma, then GPU2 Qwen, then GPT Luna) behind the existing Redis cache instead of DeepL.
|
Owner
Author
|
Danger warnings:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reply_shapeonly re-samples once: when the opening repeats one of the last eight replies, or when the reply announces a generation that no call started. Custom personas are never re-sampled.$/;command uses the deterministic table handler again. A rates request in conversation callscurrency_rates, which now sends the same rich table as the reply and ends the turn.%shortcut intent and thedraw_apitool work for global admins only. Other users get a failure that points the model todraw_image.translate_textuses a routed LLM request (newtranslationworkflow, migration 207, same chain as dialog) behind the existing Redis translation cache, instead of DeepL.Prompt replay
120 production dialog requests with untrimmed history, plus 19 requests that call tools, replayed against the dialog model:
Migration notes
207_translation_workflowinserts thetranslationworkflow (lane priority 1). It creates the primary and fallback assignments only when the primary model exists and the workflow has no assignments yet. The down migration deletes the workflow, and the delete cascades to its assignments. Fresh installs also seed a primary at boot.Checks
cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo test -p openplotva-dialog -p openplotva-llm -p openplotva-prompts -p openplotva-storage -p openplotva-app