Repository navigation
Release S1API 3.2.1 for Schedule I 0.4.7 - #361
Merged
Merged
Conversation
fix(beta): support Schedule I 0.4.7
fix(avatar): restore beta portraits and preview poses
fix(NPC): initialize plain custom NPC data on 0.4.7 beta
fix: support plain custom NPCs on f6 beta
chore(release): prepare S1API 3.2.1-beta.4
fix(Delivery): avoid unused vehicle wrapping when opening Gamepad
fix(NPC): prevent post-load custom contact reinitialization on beta
chore(release): prepare S1API 3.2.1-beta.5
fix(NPC): refresh message contact info on first load
fix(Lifecycle): detach native listeners on scene unload
* fix(NPC): retain messages across initial network spawn * fix(NPC): preserve conversation across both spawn paths
GetDerivedClasses<T> scanned every eligible assembly on each call, and custom NPC readiness calls it once per custom NPC. Results per base type are now kept per ordinary assembly until another assembly loads. Dynamic assemblies can gain types without a load event, so they stay in the plan and are re-scanned (and their eligibility re-checked) on every call. Each call returns a new list. Refs #351 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Movement presets, voice databases, NPC map PoIs and contact circles were each found with a scene or asset scan per custom NPC. They now come from a per-scene index built from one scan. Only found objects are reused, and only while alive and still under the key they were indexed by; a lookup that finds nothing scans again, so an object created later during loading is still found. Indexes clear on scene change. Refs #351 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
f11 replaced ProductIconManager.GenerateIcons (one batch at load) with on-demand GenerateRuntimeIcons(productID). The missing target made Harmony reject the whole ProductPackagingContentPatches class, so ApplyVisuals, GeneratePackagingIcon and GetIcon were unpatched too. The two batch hooks move to their own class, applied only when GenerateIcons exists; on f11 the packaging-icon prefix generates custom icons directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fix: keep packaging-content patches working on game 0.4.7f11
fix(avatar): preserve fallback portrait pose and workbench animation
fix(npc): prepare IL2CPP client customer and dealer prefabs
perf: index scene objects instead of scanning for every custom NPC
perf: keep derived-type scans until an assembly loads
chore(release): prepare 3.2.1-beta.9 prerelease
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (90)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release S1API 3.2.1 for the final Schedule I 0.4.7 Special Customers update. Integrates the validated beta series while retaining stable's documentation/contribution updates, updates project and Melon versions, and adds curated stable release notes. Refs #305.
Validation: release candidate builds with zero warnings/errors and passes 792 Mono plus 766 IL2CPP tests against final f12 references. Earlier same-behavior final-release runtime probes cover custom NPC roles, portraits, customer data, and two save loads on both runtimes; final-release multiplayer was not retested. Hosted documentation coverage, target-branch ApiCompat, coverage, and IL2CPP checks must pass before merge.
Compatibility: existing managed public signatures, save identifiers, and network payload formats are preserved, with the existing narrowly documented native PhoneApp.Exit migration suppression. This release targets game 0.4.7. No new breaking-change exceptions are introduced.
Delivery: merge with a merge commit, fast-forward releases/3.2.1 to that exact stable commit, then tag v3.2.1 for GitHub/Nexus/Thunderstore/NuGet publication. The user explicitly authorized stable releases and merging. No proprietary game references or runtime probes are included.
Summary by CodeRabbit
Compatibility
New Features
Improvements
Bug Fixes
Known Limitations