[YKWeyer]

Issue

When generating a BibTex or XML export, link fields are returned as they are stored in the database. Sometimes, it results in invalid URLs, especially when backend editors have used the link browser to link to local pages or files:

@Article { 
    …
    file_url = {t3://file?uid=331600}
    web_url = {t3://page?uid=43620}
}

Suggested changes

Extend the Controller to render all internal links when calling download Actions.

An other option would have been to edit the templates (DownloadBibtex.xml and DownloadXml.xml) to add special cases for URL fields (file_url, web_url and web_url2) and render the links there. I personnaly found it more flexible and understandable to do it within the Controller, but I can change it if you prefer to do it in the template.

Resolves #94

[tinzog]

Thanks a lot for this PR, @YKWeyer!

You asked whether to do this in the controller or in the template. We went with a third option, a domain service, and added two follow-up commits on top of your merged change:

• ce07e0e [BUGFIX] Resolve export links in a domain service and escape the XML export
• 088f49c [TEST] Add functional tests for links in BibTeX and XML exports

What changed:

• Domain service: The links are now resolved in a new PublicationExportService using TYPO3's LinkFactory. It returns the export values per publication, and the templates read them from {exportProperties.{publication.uid}}. The publications themselves are no longer modified, so absolute URLs can't end up in the database.
• Link fields: web_url, web_url2 and file_url are named explicitly instead of being read from the TCA. All their values are resolved, so page IDs and fileadmin paths also become absolute URLs.
• Unresolvable links: A link that can't be resolved (hidden or deleted page, missing file) is left out of the export instead of being exported as t3://….
• XML escaping: Generated URLs often contain & (e.g. with cHash), and the XML template ran with {escaping off}, so the file became invalid. All values in the XML export are now escaped, which also fixes the same problem for titles containing &.
• Tests: Functional tests download both exports and check the resolved links, the omitted link and that the XML is well-formed.

Thanks again for the contribution!