Skip to content

build::configure() should not put node-vX.Y.Z.lib in %LocalAppData%\Temp #107

Open

Description

@mika-fischer
  • First of all this has the potential to break CI builds in surprising ways (if temp dir is cleaned before each build)
  • It leads to the linker flag "/LIBPATH:C:\Users\\AppData\Local\Temp\" which has all kinds of interesting security implications
  • It might clash with other projects using the temp dir
  • Other projects (napi_rs, for instance) use OUT_DIR to store the lib

I can do a pull request if you want.

Activity

  1. sehz commented on Dec 9, 2020

    @sehz

    I agree, pull request will be appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions