Repository navigation
Conversation
Both pages started at '##', so they shipped with no <h1> at all while
every other page has one: nextra's h1 -> PageTitle mapping never fired,
so they also lost the page-title styling the rest of the site uses.
Verified against a local build of the patched tree: each page now emits
exactly one <h1> ('Connect Wallet', 'Verifying your Smart Contract') and
the <title> is unchanged. No anchor on the site links to either heading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
general/connect-walletandbuild/tutorials/verify-smart-contractboth start their body at##instead of#, so they are the only two live content pages on the site with no<h1>at all.Why
theme.config.mdxmapsh1to Nextra'sPageTitle, so an#heading is what gives a page its title block. With##the mapping never fires:<h1>in the document — search engines treat the missing top-level heading as a weak topic signal, and screen-reader users land in a heading tree that starts at level 2.text-3xlsection headings while every other page on the site gets thePageTitletreatment.Every other page already follows the convention; these two are the outliers:
<h1>today/general/connect-walletConnect Wallet/build/tutorials/verify-smart-contractVerifying your Smart ContractHow
Promote the first heading on each page from
##to#(and drop a trailing space on one of them). Nothing else changes.Verification
pnpm install --frozen-lockfile && pnpm run buildon the patched tree: exit 0.<h1>per page, with the expected text, and<title>is unchanged (Connect Wallet | Ink Docs,Verifying your Smart Contract | Ink Docs).pnpm run lint:mdx(remark): clean.src/links to#connect-walletor#verifying-your-smart-contract, so no inbound links break.Notes
connect-wallet, theAddNetworkButtonblocks still render their network labels ash3, so that page now goesh1 → h3for those two sub-blocks. Fixing that belongs with theh3markup in the component itself, which is under active discussion in fix: use dynamic anchor id from network prop in AddNetworkButton #607/fix(connect-wallet): give each network heading its own anchor id #662/docs: fix duplicate network anchor IDs #665 — out of scope here to keep this a two-line, conflict-free change./general/faucet,/statusand/useful-information/ink-token-contractsalso have no<h1>, but they are redirect stubs and are already covered by docs: remove orphaned stub page general/faucet.mdx #644, docs: replace client-side status stub with a server redirect #686 and docs: replace ink-token-contracts stub with a server redirect #692 respectively.