Repository navigation
Conversation
The top banner says 'Mainnet is LIVE!' but links to '/' with
target="_blank" - clicking it opens a second tab of the docs
themselves. Verified on production:
<a class="!text-white hover:!text-white/80" href="/" target="_blank" ...>
<span class="ink-typer ink-banner-typer" aria-label="Mainnet is LIVE!">
Use URLS.appUrl (https://inkonchain.com), which the footer and navbar
already use for the same destination and which is already imported in
this file for docsRepositoryBase.
Verified with a full build: the server-rendered banner now carries
href="https://inkonchain.com".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One attribute in
theme.config.tsx:<a className="!text-white hover:!text-white/80" - href="/" + href={URLS.appUrl} target="_blank" rel="noopener noreferrer" >Why
The banner across the top of every page says "Mainnet is LIVE!" — and links to
/withtarget="_blank", so clicking it opens a second tab of the docs site itself. Confirmed on production:There is no mainnet docs page it could sensibly point at; the obvious destination is the Ink app, which is exactly what
URLS.appUrl(https://inkonchain.com) holds — the same URL the footer ("App") and the navbar already link to.URLSis already imported in this file fordocsRepositoryBase.Verification
pnpm run build— exit 0href="https://inkonchain.com"prettier --check theme.config.tsxandpnpm run lint:js— clean