[C API] Add GitHub Actions workflow for building and testing C API bindings#350
Open
rfsaliev wants to merge 5 commits into
Open
[C API] Add GitHub Actions workflow for building and testing C API bindings#350rfsaliev wants to merge 5 commits into
rfsaliev wants to merge 5 commits into
Conversation
…nverter specializations In namespace svs, partial specializations of lib::DispatchConverter with a template parameter named 'Allocator' caused clang-15 (and clang-16) to incorrectly resolve the name to the class template svs::lib::Allocator, resulting in 'use of class template requires template arguments' errors. Rename the template parameter from 'Allocator' to 'Alloc' in: - bindings/c/src/data_builder/simple.hpp - bindings/c/src/data_builder/sq.hpp - bindings/c/src/data_builder/lvq.hpp - bindings/c/src/data_builder/leanvec.hpp
rfsaliev
requested review from
ahuber21,
ethanglaser,
homksei,
ibhati,
mihaic and
yuejiaointel
as code owners
|
Tick the box to add this pull request to the merge queue (same as
|
Member
Author
|
@ethanglaser, can you please review |
Member
|
Overall looks good to me. A couple questions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new GitHub Actions workflow to automate building and testing of the C API bindings, and makes several improvements to the C API test infrastructure and code quality. The changes also include minor template parameter renaming for consistency and safety checks in tests.
CI/CD Improvements:
.github/workflows/build-c-api-bindings.ymlto automatically build and test C API bindings across multiple compilers and configurations on push, PR, and manual triggers.Test Infrastructure Enhancements:
bindings/c/CMakeLists.txtby includingCTestand callingenable_testing()when C API tests are built.Code Quality and Consistency:
AllocatortoAllocinDispatchConverterspecializations withinleanvec.hpp,lvq.hpp,simple.hpp, andsq.hppfor naming consistency and clarity. [1] [2] [3] [4]Test Robustness:
run_build_and_searchinbindings/c/tests/c_api_index.cppto prevent potential crashes if storage creation fails.