Feature/oceanflow - #286
petersteneteg wants to merge 6 commits into
Conversation
| "Volume Rendering", // Category | ||
| CodeState::Stable, // Code state | ||
| Tags::GL | Tag{"Volume"} | Tag{"Raycaster"}, // Tags | ||
| R"(<Explanation of how to use the processor.>)"_unindentHelp, |
| @@ -0,0 +1,3 @@ | |||
| # OceanFlow Module | |||
|
|
|||
| Description of the OceanFlow module | |||
Cpp-Linter Report
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| *********************************************************************************/ | ||
| #pragma once | ||
|
|
||
| #include <inviwo/oceanflow/oceanflowmoduledefine.h> |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/oceanflowmodule.h:31:10: error: [clang-diagnostic-error]
'inviwo/oceanflow/oceanflowmoduledefine.h' file not found
31 | #include <inviwo/oceanflow/oceanflowmoduledefine.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~|
|
||
| namespace inviwo { | ||
|
|
||
| class IVW_MODULE_OCEANFLOW_API OceanFlowModule : public InviwoModule { |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/oceanflowmodule.h:36:32: warning: [cppcoreguidelines-avoid-non-const-global-variables]
variable 'OceanFlowModule' is non-const and globally accessible, consider making it const
36 | class IVW_MODULE_OCEANFLOW_API OceanFlowModule : public InviwoModule {
| ^|
|
||
| #pragma once | ||
|
|
||
| #include <inviwo/oceanflow/oceanflowmoduledefine.h> |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/processors/oceanraycaster.h:32:10: error: [clang-diagnostic-error]
'inviwo/oceanflow/oceanflowmoduledefine.h' file not found
32 | #include <inviwo/oceanflow/oceanflowmoduledefine.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~|
|
||
| namespace inviwo { | ||
|
|
||
| class IVW_MODULE_OCEANFLOW_API NemoVolumeComponent : public ShaderComponent { |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/processors/oceanraycaster.h:48:32: warning: [cppcoreguidelines-avoid-non-const-global-variables]
variable 'NemoVolumeComponent' is non-const and globally accessible, consider making it const
48 | class IVW_MODULE_OCEANFLOW_API NemoVolumeComponent : public ShaderComponent {
| ^| FloatProperty zZoom; | ||
| }; | ||
|
|
||
| class IVW_MODULE_OCEANFLOW_API OceanRaycaster : public VolumeRaycasterBase { |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/processors/oceanraycaster.h:72:32: warning: [cppcoreguidelines-avoid-non-const-global-variables]
variable 'OceanRaycaster' is non-const and globally accessible, consider making it const
72 | class IVW_MODULE_OCEANFLOW_API OceanRaycaster : public VolumeRaycasterBase {
| ^| * | ||
| *********************************************************************************/ | ||
|
|
||
| #include <inviwo/oceanflow/oceanflowmodule.h> |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/src/oceanflowmodule.cpp:30:10: error: [clang-diagnostic-error]
'inviwo/oceanflow/oceanflowmodule.h' file not found
30 | #include <inviwo/oceanflow/oceanflowmodule.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~| * | ||
| *********************************************************************************/ | ||
|
|
||
| #include <inviwo/oceanflow/processors/oceanraycaster.h> |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/src/processors/oceanraycaster.cpp:30:10: error: [clang-diagnostic-error]
'inviwo/oceanflow/processors/oceanraycaster.h' file not found
30 | #include <inviwo/oceanflow/processors/oceanraycaster.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~| #include <warn/pop> | ||
|
|
||
| int main(int argc, char** argv) { | ||
| using namespace inviwo; |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/tests/unittests/oceanflow-unittest-main.cpp:44:5: warning: [google-build-using-namespace]
do not use namespace using-directives; use using-declarations instead
44 | using namespace inviwo;
| ^
119d093 to
ffb93db
Compare
| *********************************************************************************/ | ||
| #pragma once | ||
|
|
||
| #include <inviwo/oceanflow/oceanflowmoduledefine.h> |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/oceanflowmodule.h:31:10: error: [clang-diagnostic-error]
'inviwo/oceanflow/oceanflowmoduledefine.h' file not found
31 | #include <inviwo/oceanflow/oceanflowmoduledefine.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~|
|
||
| namespace inviwo { | ||
|
|
||
| class IVW_MODULE_OCEANFLOW_API OceanFlowModule : public InviwoModule { |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/oceanflowmodule.h:36:32: warning: [cppcoreguidelines-avoid-non-const-global-variables]
variable 'OceanFlowModule' is non-const and globally accessible, consider making it const
36 | class IVW_MODULE_OCEANFLOW_API OceanFlowModule : public InviwoModule {
| ^|
|
||
| #pragma once | ||
|
|
||
| #include <inviwo/oceanflow/oceanflowmoduledefine.h> |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/processors/oceanraycaster.h:32:10: error: [clang-diagnostic-error]
'inviwo/oceanflow/oceanflowmoduledefine.h' file not found
32 | #include <inviwo/oceanflow/oceanflowmoduledefine.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~|
|
||
| namespace inviwo { | ||
|
|
||
| class IVW_MODULE_OCEANFLOW_API NemoVolumeComponent : public ShaderComponent { |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/processors/oceanraycaster.h:48:32: warning: [cppcoreguidelines-avoid-non-const-global-variables]
variable 'NemoVolumeComponent' is non-const and globally accessible, consider making it const
48 | class IVW_MODULE_OCEANFLOW_API NemoVolumeComponent : public ShaderComponent {
| ^| FloatProperty zZoom; | ||
| }; | ||
|
|
||
| class IVW_MODULE_OCEANFLOW_API OceanRaycaster : public VolumeRaycasterBase { |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/processors/oceanraycaster.h:72:32: warning: [cppcoreguidelines-avoid-non-const-global-variables]
variable 'OceanRaycaster' is non-const and globally accessible, consider making it const
72 | class IVW_MODULE_OCEANFLOW_API OceanRaycaster : public VolumeRaycasterBase {
| ^| * | ||
| *********************************************************************************/ | ||
|
|
||
| #include <inviwo/oceanflow/oceanflowmodule.h> |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/src/oceanflowmodule.cpp:30:10: error: [clang-diagnostic-error]
'inviwo/oceanflow/oceanflowmodule.h' file not found
30 | #include <inviwo/oceanflow/oceanflowmodule.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~| * | ||
| *********************************************************************************/ | ||
|
|
||
| #include <inviwo/oceanflow/processors/oceanraycaster.h> |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/src/processors/oceanraycaster.cpp:30:10: error: [clang-diagnostic-error]
'inviwo/oceanflow/processors/oceanraycaster.h' file not found
30 | #include <inviwo/oceanflow/processors/oceanraycaster.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~| #include <warn/pop> | ||
|
|
||
| int main(int argc, char** argv) { | ||
| using namespace inviwo; |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/tests/unittests/oceanflow-unittest-main.cpp:44:5: warning: [google-build-using-namespace]
do not use namespace using-directives; use using-declarations instead
44 | using namespace inviwo;
| ^
ffb93db to
db63b5a
Compare
| * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| * | ||
| *********************************************************************************/ | ||
| #pragma once |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/oceanflowmodule.h:29:1: warning: [portability-avoid-pragma-once]
avoid 'pragma once' directive; use include guards instead
29 | #pragma once
| ^| *********************************************************************************/ | ||
| #pragma once | ||
|
|
||
| #include <inviwo/oceanflow/oceanflowmoduledefine.h> |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/oceanflowmodule.h:31:10: error: [clang-diagnostic-error]
'inviwo/oceanflow/oceanflowmoduledefine.h' file not found
31 | #include <inviwo/oceanflow/oceanflowmoduledefine.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~|
|
||
| namespace inviwo { | ||
|
|
||
| class IVW_MODULE_OCEANFLOW_API OceanFlowModule : public InviwoModule { |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/oceanflowmodule.h:36:32: warning: [cppcoreguidelines-avoid-non-const-global-variables]
variable 'OceanFlowModule' is non-const and globally accessible, consider making it const
36 | class IVW_MODULE_OCEANFLOW_API OceanFlowModule : public InviwoModule {
| ^| @@ -0,0 +1,22 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/oceanflowmoduledefine.h:1:1: warning: [portability-avoid-pragma-once]
avoid 'pragma once' directive; use include guards instead
1 | #pragma once
| ^| * | ||
| *********************************************************************************/ | ||
|
|
||
| #pragma once |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/processors/oceanraycaster.h:30:1: warning: [portability-avoid-pragma-once]
avoid 'pragma once' directive; use include guards instead
30 | #pragma once
| ^|
|
||
| namespace inviwo { | ||
|
|
||
| class IVW_MODULE_OCEANFLOW_API NemoVolumeComponent : public ShaderComponent { |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/processors/oceanraycaster.h:48:32: warning: [cppcoreguidelines-avoid-non-const-global-variables]
variable 'NemoVolumeComponent' is non-const and globally accessible, consider making it const
48 | class IVW_MODULE_OCEANFLOW_API NemoVolumeComponent : public ShaderComponent {
| ^| FloatProperty zZoom; | ||
| }; | ||
|
|
||
| class IVW_MODULE_OCEANFLOW_API OceanRaycaster : public VolumeRaycasterBase { |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/processors/oceanraycaster.h:72:32: warning: [cppcoreguidelines-avoid-non-const-global-variables]
variable 'OceanRaycaster' is non-const and globally accessible, consider making it const
72 | class IVW_MODULE_OCEANFLOW_API OceanRaycaster : public VolumeRaycasterBase {
| ^| * | ||
| *********************************************************************************/ | ||
|
|
||
| #include <inviwo/oceanflow/oceanflowmodule.h> |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/src/oceanflowmodule.cpp:30:10: error: [clang-diagnostic-error]
'inviwo/oceanflow/oceanflowmodule.h' file not found
30 | #include <inviwo/oceanflow/oceanflowmodule.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~| * | ||
| *********************************************************************************/ | ||
|
|
||
| #include <inviwo/oceanflow/processors/oceanraycaster.h> |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/src/processors/oceanraycaster.cpp:30:10: error: [clang-diagnostic-error]
'inviwo/oceanflow/processors/oceanraycaster.h' file not found
30 | #include <inviwo/oceanflow/processors/oceanraycaster.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~| #include <warn/pop> | ||
|
|
||
| int main(int argc, char** argv) { | ||
| using namespace inviwo; |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/tests/unittests/oceanflow-unittest-main.cpp:44:5: warning: [google-build-using-namespace]
do not use namespace using-directives; use using-declarations instead
44 | using namespace inviwo;
| ^
db63b5a to
207b0ac
Compare
| *********************************************************************************/ | ||
| #pragma once | ||
|
|
||
| #include <inviwo/oceanflow/oceanflowmoduledefine.h> |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/oceanflowmodule.h:31:10: error: [clang-diagnostic-error]
'inviwo/oceanflow/oceanflowmoduledefine.h' file not found
31 | #include <inviwo/oceanflow/oceanflowmoduledefine.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~|
|
||
| namespace inviwo { | ||
|
|
||
| class IVW_MODULE_OCEANFLOW_API OceanFlowModule : public InviwoModule { |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/oceanflowmodule.h:36:32: warning: [cppcoreguidelines-avoid-non-const-global-variables]
variable 'OceanFlowModule' is non-const and globally accessible, consider making it const
36 | class IVW_MODULE_OCEANFLOW_API OceanFlowModule : public InviwoModule {
| ^|
|
||
| #pragma once | ||
|
|
||
| #include <inviwo/oceanflow/oceanflowmoduledefine.h> |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/processors/oceanraycaster.h:32:10: error: [clang-diagnostic-error]
'inviwo/oceanflow/oceanflowmoduledefine.h' file not found
32 | #include <inviwo/oceanflow/oceanflowmoduledefine.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~|
|
||
| namespace inviwo { | ||
|
|
||
| class IVW_MODULE_OCEANFLOW_API NemoVolumeComponent : public TemporalVolumeComponent { |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/processors/oceanraycaster.h:49:32: warning: [cppcoreguidelines-avoid-non-const-global-variables]
variable 'NemoVolumeComponent' is non-const and globally accessible, consider making it const
49 | class IVW_MODULE_OCEANFLOW_API NemoVolumeComponent : public TemporalVolumeComponent {
| ^| FloatProperty zZoom; | ||
| }; | ||
|
|
||
| class IVW_MODULE_OCEANFLOW_API VolumeMaskComponent : public ShaderComponent { |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/include/inviwo/oceanflow/processors/oceanraycaster.h:62:32: warning: [cppcoreguidelines-avoid-non-const-global-variables]
variable 'VolumeMaskComponent' is non-const and globally accessible, consider making it const
62 | class IVW_MODULE_OCEANFLOW_API VolumeMaskComponent : public ShaderComponent {
| ^| * | ||
| *********************************************************************************/ | ||
|
|
||
| #include <inviwo/oceanflow/oceanflowmodule.h> |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/src/oceanflowmodule.cpp:30:10: error: [clang-diagnostic-error]
'inviwo/oceanflow/oceanflowmodule.h' file not found
30 | #include <inviwo/oceanflow/oceanflowmodule.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~| * | ||
| *********************************************************************************/ | ||
|
|
||
| #include <inviwo/oceanflow/processors/oceanraycaster.h> |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/src/processors/oceanraycaster.cpp:30:10: error: [clang-diagnostic-error]
'inviwo/oceanflow/processors/oceanraycaster.h' file not found
30 | #include <inviwo/oceanflow/processors/oceanraycaster.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~| }} | ||
| {0}ValuePrev = {0}Value; | ||
| )"); | ||
| } |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/src/processors/oceanraycaster.cpp:164:1: warning: [google-readability-namespace-comments]
anonymous namespace not terminated with a closing comment
164 | }
| ^
/home/runner/work/modules/modules/inviwo/infravis/oceanflow/src/processors/oceanraycaster.cpp:132:11: note: anonymous namespace starts here
note: cannot apply fix-it because an alias checker has suggested a different fix-it; please remove one of the checkers ('google-readability-namespace-comments', 'llvm-namespace-comment') or ensure they are both configured the same
132 | namespace {
| ^| {0}ValuePrev = {0}Value; | ||
| )"); | ||
| } | ||
| } // namespace |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/src/processors/oceanraycaster.cpp:165:2: warning: [google-readability-namespace-comments]
namespace 'mask' ends with a comment that refers to a wrong namespace ''
165 | } // namespace
| ^
/home/runner/work/modules/modules/inviwo/infravis/oceanflow/src/processors/oceanraycaster.cpp:131:11: note: namespace 'mask' starts here
note: cannot apply fix-it because an alias checker has suggested a different fix-it; please remove one of the checkers ('google-readability-namespace-comments', 'llvm-namespace-comment') or ensure they are both configured the same
131 | namespace mask {
| ^| #include <warn/pop> | ||
|
|
||
| int main(int argc, char** argv) { | ||
| using namespace inviwo; |
There was a problem hiding this comment.
clang-tidy diagnostic
infravis/oceanflow/tests/unittests/oceanflow-unittest-main.cpp:44:5: warning: [google-build-using-namespace]
do not use namespace using-directives; use using-declarations instead
44 | using namespace inviwo;
| ^2 participants
No description provided.