Skip to content

Add --progress-images to CLI - #623

Closed
kevinschaul wants to merge 1 commit into
invoke-ai:mainfrom
kevinschaul:cli-progress-images
Closed

Add --progress-images to CLI#623
kevinschaul wants to merge 1 commit into
invoke-ai:mainfrom
kevinschaul:cli-progress-images

Conversation

@kevinschaul

Copy link
Copy Markdown
Contributor

Uses similar code to the web GUI for saving intermediate images.

Fixes #75
Fixes #99
Fixes #154
Fixes #224

Uses similar code to the web GUI for saving intermediate images.

Fixes invoke-ai#75
Fixes invoke-ai#99
Fixes invoke-ai#154
Fixes invoke-ai#224
@tildebyte

Copy link
Copy Markdown
Contributor

Are you sure this fixes #75?

@blessedcoolant

blessedcoolant commented Sep 17, 2022

Copy link
Copy Markdown
Collaborator

I did some testing on this. Here are my notes.

  1. Shorten the switch to just -save_progress in my opinion. It'll be in sync with -save_orig that we already have.
  2. Change -save_progress from being just a switch to actually taking step values from user. For example: let -save_progress 5 with 5 being the controller for the step count.
  3. You need to rebase this on top of the development changes. A lot of refactoring was done. So you'll need to update your code.
  4. Even saving an image per step, I did not see any drastic performance loss. It's pretty fast.

@lstein

lstein commented Sep 19, 2022

Copy link
Copy Markdown
Collaborator

@kevinschaul, thank you so much for contributing this nice feature. As my collaborators have mentioned, it would be best if you could rebase this PR against the development branch. The code is evolving quickly, and over time it becomes increasingly difficult to merge in contributions. I hope you understand.

@blessedcoolant

Copy link
Copy Markdown
Collaborator

@kevinschaul @lstein I have a very nice implementation of this feature locally using -save_progress. I think I will make a new PR with that feature added to this and add kevin as the co-author.

@kevinschaul

Copy link
Copy Markdown
Contributor Author

Hi all, apologies I was away from keyboard this weekend. Thanks for all the tips. I'm happy to close this and help get #694 merged instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants