docs: expand the testing guide with frontend commands - #9294
Conversation
joshistoast
left a comment
There was a problem hiding this comment.
Reviewing from my phone rn, this looks fairly above board. A couple non-blockers I'd probably change though:
-
Not sure it's worth talking about where to expect the test files and then afterwards say that a lot don't follow that expectation.
-
Maybe we can mention the makefile commands we have for running the testing suite. Either as an additional set of commands or replace the mentioned ones.
|
Thanks for the suggestions — I've updated the guide to address both points.
Happy to make another pass if you'd prefer a different command mix. |
joshistoast
left a comment
There was a problem hiding this comment.
These look good, maybe separate the make and pnpm tests with starlight tabs and I'll approve
|
@wunianze666-netizen This is ready to go after you address @joshistoast 's request to put the docs in separate starlight tabs. |
|
Thanks, I've separated the frontend commands into Starlight tabs:
I also rebased the branch on the latest |
|
Thanks for catching that. I added the missing Starlight component import in I also installed the docs dependencies and ran |
|
Synced the branch with the current I reran the full docs build after the sync: 314 pages generated and all internal links valid. I also marked the now-addressed import thread as resolved. @joshistoast, could you please re-review when convenient? |
Summary
invokeai/frontend/webWhy
The testing guide currently exposes an unfinished TODO in the published docs. This change makes the page immediately usable for contributors who want to run frontend tests locally.