This repository was archived by the owner on Apr 16, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 16, 2020. It is now read-only.
Move coverage test to Circle CI (now it is on Travis) #6
Description
@victorbjelkholm can you use your script to move all the Coverage runs to Circle CI instead of Travis?
Currently, it is https://github.com/ipfs/js-ipfs-repo/blob/master/.travis.yml#L21-L22, we want https://github.com/ipfs/js-ipfs-api/blob/master/circle.yml#L7
We also want to default to coveralls and not codecov. Make the line be:
npm run coverage -- --upload --providers coveralls
Thank you!
Activity
victorb commentedon Dec 22, 2017
Is this something that is urgent and needs to be changed now? Otherwise, we can proceed as we are with updating CI everywhere, and once migration is done, I can write a script that can change that directly in master, bypassing the PRs.
daviddias commentedon Dec 22, 2017
@victorbjelkholm we want coverage to be run on PRs so that we know if the PR is lowering or increasing the coverage.
Right now we have a bunch of unknowns here https://github.com/ipfs/js-ipfs#packages
daviddias commentedon Feb 18, 2018
@victorbjelkholm I see that the config was updated -- https://github.com/ipfs/ci-sync/blob/master/configs/circle.yml#L11 -- but there hasn't been a PR to change this in all the repos. What's the hold up?
victorb commentedon Feb 18, 2018
@diasdavid I want to change the flow of the script before running it again, as it's destructive, see https://github.com/ipfs/ci-sync/blob/master/make-ci-update-pr.js#L25