Repository navigation
Conversation
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
fallenmi
force-pushed
the
agent/fix-nonzero-as-tuple
branch
from
August 25, 2026 12:46
39cd112 to
b94c64a
Compare
fallenmi
marked this pull request as ready for review
August 25, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
Tensor.nonzero()called its two existing core methods from the oppositeas_tuplebranches. As a result, the default and explicitFalsereturned a per-dimension list, whileTruereturned a single tensor.This restores the branch mapping that existed before the pure-C++ pybind rewrite. It intentionally preserves Open3D's existing
[num_dims, num_non_zeros]tensor orientation and the historical per-dimension list behavior. Changing the orientation or introducing a literal Python tuple is outside this bug fix.Checklist
False, andTruepaths.Description
Plan summary:
False, andTruepaths.NonZeroandNonZeroNumpycalls.Validation recorded for the original branch on macOS arm64 with AppleClang 21 and Python 3.14:
main: the focused regression failed because the default path returned a list.python/test/core/test_core.py: 279 passed.python util/check_style.py --apply --no_parallel: passed.git diff --check: passed.Rebase validation on 2026-08-25:
aab533fonto22a6a30and resolved only the additiveCHANGELOG.mdconflict.git diff --checkpassed.AI assistance disclosure: OpenAI Codex investigated, implemented, rebased, and validated this change. The GitHub account owner explicitly authorized publication and automated branch and pull-request updates.