fix: register ini codec for config loading#211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unblocks #193. Viper 1.20 removed built-in INI support, and INI is the default config format for ipctl, so the Dependabot bump breaks all config loading (
decoder not found for this format) and hangsTestConfigLoadingIsThreadSafeuntil the CI test timeout. This PR upgrades Viper to 1.21.0 and restores INI support by registering the codec Viper extracted (github.com/go-viper/encoding/ini).Type of Change
Changes Made
spf13/viper1.19.0 -> 1.21.0 and vendorgo-viper/encoding/iniviper.NewCodecRegistry()inLoader.Load(); the registry falls back to built-in YAML, JSON, and TOML codecs for other formatsTestConfigLoadingIsThreadSafeto count failed goroutines as completed, so config errors fail in seconds instead of deadlocking CITesting
make testpasses;internal/configcompletes in 0.3s (previously hung on Viper 1.21)--config, extensionless~/.platform.d/config, andconfig.inidiscovery; YAML configs still load through the codec-registry fallback; malformed INI returns a clear parse errorgo-licenses reportpassesChecklist