Repository navigation
fix: restore harness discovery and chat recovery - #31
Merged
Merged
Conversation
Encode workflow and check names as a JSON tuple so distinct pairs cannot collide and hide a failed check. Preserve newest-run deduplication within each pair. Backport upstream 5e5c52b (pingdotgg#19162), including its regression test. Validated regression failure before the fix, 22 focused tests, source-control-core typecheck, targeted lint/format, and false-green watcher reproduction. Co-authored-by: Simone <lucenz@proton.me>
Setup counters reset after the tracker retention window. Order snapshots by attempt start time before sequence so a new running attempt replaces an older completed or failed snapshot. Reuse the selector for held, rendered, and recorded progress while preserving out-of-order protection within an attempt. Verified the regression failed before the fix; 344 focused tests, web and client-runtime typechecks, targeted lint, and formatting checks pass. Original duplicate loading display remains pending authenticated browser reproduction.
Gateway presence blocked native Antigravity configuration even when native credentials were supplied. Preserve its native route and skip gateway discovery for its worker operations. Cover configuration, model discovery, session opening, and retained credentials with gateway mode on and off.
The composer required native history before allowing an idle thread without a session to switch providers. A failed first startup never creates that history, even though V2 supports recovering through a portable handoff. Allow selection when no session or active run exists. Preserve negotiated capability checks and active-run locks. Cover the client gate, server transition plan, and failed-start recovery with original prompt delivery.
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
jake-molnia
marked this pull request as ready for review
October 17, 2026 20:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sweep fixes native Antigravity routing, stale gateway discovery, misleading harness configuration, and recovery paths that could leave chats or workspace progress stuck.
Validation: integrated focused batches pass with 194, 347, and 104 tests, plus 310 after the immediate-composer follow-up. Affected server, web, client-runtime, and source-control-core typechecks pass. Owners demonstrated failing regressions before fixes. The pinned proxy patch applies cleanly and its focused Go tests pass. Independent review found no blocker in the native/gateway boundaries.
Browser verification uses isolated copied state, not live user data. Desktop comparison confirms five old rows with five toggles become eight configuration rows without list toggles. Native Antigravity fields remain visible; its disabled preference survives reload; the 390px mobile viewport has no document overflow. Download the browser evidence HTML to view embedded before/after screenshots, mobile layout, and the setup-stream replay video. The replay confirms a new sequence-0 attempt replaces an old sequence-9 attempt and rejects a late old event. Delayed-default browser acceptance passes: the mounted draft opens while pending, retains typing, resolves to worktree mode, and preserves an explicit override against a late result.
Live runtime diagnosis measured a controlled fresh cross-worker path at 21.427s and retained seeded resume at 5.4s. T3 uses direct Sandbox resources, not the unrelated devbox warm pool. No runtime/capacity change is included. The original user attempt, duplicate-loading report, and exact active-chat screenshot state were not reproduced. Live Google OAuth and model-turn acceptance remain rollout checks.
Implemented and reviewed with GPT-6 Astra through the Codex harness in T3 Code.
Rollout configuration must add Antigravity to both execution-pool driver allowlists. Native sign-in uses a utility path, but starting a chat enforces the pool list.