`${name}-${version}-runnable.jar` is not found in deployment directory

[fvarrui]

There is now a new issue. The ${name}-${version}-runnable.jar is not found in deployment directory. In the deployement directory i find ${name}.jar without version and 'runnable'.

Am i missing some configuration details that i have to consider in the new Version?

The very last step during packaging seems to rename the build artifact jar file.
This is the message:

Concatenating files [/target/deploy/linux/assets/startup.sh,/target/deploy/linux/name-version-runnable.jar] into file [/target/deploy/linux/<name>.jar]

best,
Kia

Originally posted by @kia in #335 (comment)

[fvarrui]

@kia

There is now a new issue. The ${name}-${version}-runnable.jar is not found in deployment directory. In the deployement directory i find ${name}.jar without version and 'runnable'.

As I'm seeing in your output, the runnable JAR should be in target/deploy/linux, as you are setting outputDirectory option pointing to this directory. The runnable JAR file is not there?

Am i missing some configuration details that i have to consider in the new Version?

I think nothing has been changed.

The very last step during packaging seems to rename the build artifact jar file. This is the message:

Concatenating files [/target/deploy/linux/assets/startup.sh,/target/deploy/linux/name-version-runnable.jar] into file [/target/deploy/linux/<name>.jar]

The runnable JAR is concatenated to the BASH script in order to create the executable.

I guess you made a mistake here: Concatenating files [/target/deploy/linux/assets/startup.sh,/target/deploy/linux/name-version-runnable.jar] into file [/target/deploy/linux/<name>] ... the destination of concat is not a JAR file, right?

[kia]

Hi @fvarrui

I didn't change the configuration in our pom.xml . The only thing i changed was the version number of the java packager from 1.7.2 to 1.7.3 and suddenly this error occurred. When i go back to the older version of the javapackager then it works again.

But to answer your last question: the destination of concat is an executable on linux. But then there is a <name>-runnable.jar in that directory instead of a <name>-<version>-runnable.jar

[kia]

In git i found that in 1.7.3 in the class io.github.fvarrui.javapackager.maven.CreateRunnableJar the line (number 91)
element("finalName", name + "-" + version)
is removed in the new Version.
This could be the cause of the problem.
I added this line again rebuild the JavaPackager and the issue is gone.

[fvarrui]

WoW!! 😮 Yes, you are right. This change was made to avoid a warning message, since new versions of maven-jar-plugin set finalName option as deprecated. If you are sure this fixes the problem, I'm going to revert this change and released a patch as 1.7.4

[kia]

Hi @fvarrui,
I see the change in maven-jar-plugin. Here is explained how to define the finalName in the correct way and if I define the finalName in our pom.xml as ${name}-${version} then every thing works again without adding the deprecated parameter in io.github.fvarrui.javapackager.maven.CreateRunnableJar.
If i leave it as ${name} then the problem occur.

I think the real issue is here:
File finalJarFile = new File(outputDirectory, name + "-" + version + "-" + classifier + ".jar");
where you create the fineJarFile. May be the finalJarFile should be new File(outputDirectory, finalName + "-" + classifier + ".jar");

Best,
Kia

[fvarrui]

Are you setting finalName in your POM? I mean ... maybe this was causing this issue by modifying maven-jar-plugin behaviour, since CreateRunnableJar expects a different JAR filename.

[fvarrui]

May be the finalJarFile should be new File(outputDirectory, finalName + "-" + classifier + ".jar");

Good point! I'll do some research about this

[kia]

Are you setting finalName in your POM? I mean ... maybe this was causing this issue by modifying maven-jar-plugin behaviour, since CreateRunnableJar expects a different JAR filename.

yes. exactly. As soon as i set the finalName as ${name}-${version} everything is fine. But I would like to set the finalName as ${name}. Then there is the mismatch and the issue occur.

[fvarrui]

yes. exactly. As soon as i set the finalName as ${name}-${version} everything is fine. But I would like to set the finalName as ${name}. Then there is the mismatch and the issue occur.

Ok, I guessed so ... I'm working right now on this issue. I just found how to get finalName programatically, so we can determine the right name of the generated runnable JAR file

[fvarrui]

Just patched in branch issue-355.

Try snapshot version 1.7.4-20230821.162917-2 and give some feedback, please.