Repository navigation
Fix -Werror=comment in profile_stress.cc (unblock fork main CI) - #45
Merged
Merged
Conversation
Trailing backslashes on // comment lines line-continued the comment into the next source line, which gcc -Werror=comment flags. They were intended as shell continuations in the example commands but have no meaning inside a C++ comment. Drop the backslashes; the example reads the same. Unblocks ubuntu-24.04 Release / Debug builds on fork main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
//comment lines atsrc/test/perf/profile_stress/profile_stress.cc:13,19,20//into the next source line, which gcc rejects under-Werror=commentubuntu-24.04 Release / build,ubuntu-24.04 Debug / build, and all downstream jobs that depend on a clean library build (~20 failing jobs on current fork main)Diagnosis
Failing job: https://github.com/jayakasadev/snmalloc/actions/runs/27385175943/job/80995619632
This was introduced in fork PR #24 (Phase 7.4 stress test) but missed by CI because the stress test was only built in the post-merge sanitizer matrix that does not gate.
Test plan
cmake -B build -DSNMALLOC_PROFILE=ON && cmake --build build --target perf-profile_stress-fastbuilds clean