feat(executor): implement LENGTH [CLAUDE] - #4
Closed
jbylund wants to merge 1 commit into
Closed
Conversation
LENGTH was absent from the executor's ENV, so any query calling it raised `name 'LENGTH' is not defined` rather than answering. char_length() parses to the same node, so it was unavailable too. null_if_any(len) matches Postgres on all three cases: 3 for 'abc', 0 for the empty string, and NULL for NULL.
Owner
Author
|
Superseded — LENGTH landed upstream as tobymao#8145 and is already in this fork's main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened against my own fork first for review.
LENGTHis absent from the executor'sENV, so any query calling it raises rather than answering:char_length()parses to the same node, so it was unavailable too.null_if_any(len)matches Postgres on all three cases — checked against a real PostgreSQL 18:One line, plus a test covering both spellings. Full suite: 1318 tests, OK.