Head of build log is not useful in failures

@jglick

Looks like https://ci.jenkins.io/job/Tools/job/bom/job/master/1751/ failed at the infrastructure level. Unfortunately https://plugins.jenkins.io/github-checks/ (unlike https://docs.cloudbees.com/docs/cloudbees-ci/latest/scm-integration/enabling-scm-reporting#_cloudbees_scm_reporting_feature_benefits) includes the head rather than the tail of a failed shell step’s log, which is usually useless, and does not link to the execution/node/*/log/ for the build-terminating error.

Originally posted by @jglick in jenkinsci/bom#2121 (comment)

@timja

@timja Is this something the Jenkins maintainers can help implement or are you open for community contribution for this? I assume we just need to change

github-checks-plugin/src/main/java/io/jenkins/plugins/checks/github/GitHubChecksDetails.java

Lines 173 to 178 in 9e25889

    
           Output output = new Output( 
        
                   checksOutput.getTitle().orElseThrow( 
        
                           () -> new IllegalArgumentException("Title of output is required but not provided")), 
        
                   checksOutput.getSummary(MAX_MESSAGE_SIZE_TO_CHECKS_API).orElseThrow( 
        
                           () -> new IllegalArgumentException("Summary of output is required but not provided"))) 
        
                   .withText(checksOutput.getText(MAX_MESSAGE_SIZE_TO_CHECKS_API).orElse(null));

and put it behind a config somewhere? Or do you think we can make a non-backward compatible change to show the last part of the log for everyone?

Open to community contribution, I think we can just change it for everyone

@timja

Hi @timja hoping you can review the PR I just opened for this topic ^

@timja

Hi @timja when you get a moment I opened a follow up pr on this issue. Let me know if you want to change anything. jenkinsci/checks-api-plugin#272

cc: @tabletenniser

Navigation Menu

Repository navigation

Head of build log is not useful in failures #343

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	Output output = new Output(
	checksOutput.getTitle().orElseThrow(
	() -> new IllegalArgumentException("Title of output is required but not provided")),
	checksOutput.getSummary(MAX_MESSAGE_SIZE_TO_CHECKS_API).orElseThrow(
	() -> new IllegalArgumentException("Summary of output is required but not provided")))
	.withText(checksOutput.getText(MAX_MESSAGE_SIZE_TO_CHECKS_API).orElse(null));

Head of build log is not useful in failures #343

Description

Activity

tabletenniser commented on Feb 1, 2025

timja commented on Feb 1, 2025

sarahdeitke commented on Feb 5, 2025

sarahdeitke commented on Feb 14, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions