Repository navigation
Bump go version to 1.26 - #6137
Merged
Merged
Conversation
Two places pass plain text as the format string of TextStyle.Sprintf without further arguments: the prefix of a disabled menu item's tooltip, and the key binding entries of the options bar. If the text contains a "%", for example in a translation or in a key label, it is mangled into something like "%!(NOVERB)". go vet doesn't report these calls yet. It will once go.mod says go 1.26, because vet then also finds printf wrappers through interface methods. TextStyle.Sprintf forwards to the Sprintf method of the Sprinter interface. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Updating Go means editing the go-version of six setup-go steps in ci.yml. The workflow defines a GO_VERSION variable for this, but no step has used it since it was added in a34bdf1. Use it in all six steps. Give its value the ".x" suffix so that setup-go keeps picking the latest patch release. This also keeps YAML from reading a version like 1.30 as the number 1.3. release.yml still needs its own update, because env variables don't carry over to other workflows. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Dependabot PRs that update golang.org/x modules fail on CI. These modules now require go 1.26, but CI runs 1.25. The golang.org/x modules require the oldest Go release that is still supported, and since Go 1.27 came out, this is 1.26. Stop at 1.26 rather than going to 1.27. The go version in go.mod is the minimum for everyone who builds lazygit from source, and Go 1.27 is only two months old. Also, Go 1.27 requires macOS 13, so release binaries built with it would no longer run on macOS 12. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of our dependencies require 1.26 now, in particular golang.org/x.