Deploy the preflight agent#15
Merged
Merged
Conversation
wallrj
force-pushed
the
deploy-preflight-agent
branch
from
February 10, 2021 16:02
75f0022 to
e23d444
Compare
Contributor
Author
|
The cloudbuild succeeds but with the following expected errors reported: I'm surprised that verify succeeds, but perhaps that's going to get better with @maelvls 's smoke tests #5 |
Member
|
Might be worth adding a line in the readme that explains why we went with the single-tag-approach, e.g, This application re-tags the various images (cert-manager, cas-issuer, ubbagent, preflight-agent) using
a unified tag that we call "application version". Although it does not appear to be a requirement for
releasing to the Google Marketplace, we were not able to set "default" tags for each image and thus
resolved to just having a unified tag; this means that we will have to keep this difference in tags when
supporting [jetstack-secure-for-cert-manager][].
[jetstack-secure-for-cert-manager]: https://console.cloud.google.com/partner/editor/jetstack-public/jetstack-secure-for-cert-manager?project=jetstack-public |
maelvls
reviewed
Feb 10, 2021
Comment on lines
+13
to
+21
| - name: preflight | ||
| version: 0.1.0 | ||
| appVersion: 0.1.27 | ||
| repository: ./charts/preflight |
Member
There was a problem hiding this comment.
Might be worth adding a note at the top of Chart.yaml that says smth like
# The appVersion below are overridden by the `publishedVersion` that is set in
# `schema.yaml`. Changing the below version will not change the actual versions
# being pulled when the application is deployed from the Google Marketplace.
# Instead, you should update the image tags that are being re-tagged in
# `cloudbuild.yml`
Member
|
Excellent!! Two tiny nits about documentation (see above) @wallrj |
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
wallrj
force-pushed
the
deploy-preflight-agent
branch
from
February 11, 2021 18:13
a092ba8 to
bd1a738
Compare
Contributor
Author
|
Hey @maelvls I added those explanatory comments and rebased. gcloud build succeeds...FWIW PTAL |
Contributor
Author
|
/assign @maelvls |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy the preflight agent alongside cert-manager and google-cas-issuer
Fixes: #8