Repository navigation
🤖 test: once listener removed before reentrant emit (#226) - #228
Merged
Merged
Conversation
A once handler that emits the same event from inside itself must not run again. Issue jfhbrook#226 asked for this check as a test. EventEmitter already removes the listener before the callback. This commit adds no public API change. AI tooling wrote this change. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #226. The issue asked whether a once handler that emits the same event from inside itself belongs in the docs. @jfhbrook suggested a test, and @PerchAnton agreed and posted a candidate for
tests/test_sync.py.EventEmitter.oncealready removes the listener before the callback; this adds that coverage and leaves the public API alone.What changed
test_once_is_removed_before_reentrant_emitrecords the call order when a once handler emits the same event from inside itself (once → nested persistent → outer persistent), then checks a later emit only hits the persistent listener.Scope
EventEmitteronly.Verification
just qapassed on this diff.AI tooling was used for this change (🤖 commit marker per DEVELOPMENT.md).