Fail closed when LLM generation tunables are not YAML numbers - #117
Merged
Conversation
bool is a subclass of int, so narration_from_source.temperature: true became 1.0 and max_context_bytes: true became a 1-byte prompt window. Co-authored-by: jmjava <jmjava@gmail.com>
Record PR #117 and pytest / benchmark results on the milestone. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 21:49
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
narration-generate/scene-spec-generatewrap generation tunables infloat()/int(). A YAML bool is a subclass ofint, so:narration_from_source.temperature: truebecame temperature 1.0max_context_bytes: truebecame a 1-byte context windowmax_whisper_words_in_prompt: truebecame 1 (truncate the word stream)A YAML list or string raised
TypeError/ValueErrorat generate time, notConfigErrorat load.Change
Present values of
narration_from_source.temperature/max_context_bytes,manim_scene_generation.temperature/max_context_bytes, and themax_whisper_*caps must be YAML numbers (int or float, not bool). Missing keys keep defaults.Milestone:
milestones/generation-numeric-tunables.mdTests
temperaturerejectedmax_context_bytesrejectedmax_whisper_words_in_promptrejected